Skip to content

Backend/push: Fix ios_title not being used.#8495

Merged
tristanlabelle merged 4 commits into
developfrom
backend/bugfix/push-use-ios_title
May 9, 2026
Merged

Backend/push: Fix ios_title not being used.#8495
tristanlabelle merged 4 commits into
developfrom
backend/bugfix/push-use-ios_title

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented May 9, 2026

Copy link
Copy Markdown
Contributor

The point of ios_title is to be shorter than title since it is accompanied with ios_subtitle.

Testing

Added some tests.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 9, 2026 3:00pm

Request Review

@tristanlabelle
tristanlabelle marked this pull request as ready for review May 9, 2026 23:15
@tristanlabelle
tristanlabelle requested a review from aapeliv as a code owner May 9, 2026 23:15
@tristanlabelle
tristanlabelle requested review from a team and WouldYouKindly May 9, 2026 23:15

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tristanlabelle
tristanlabelle merged commit 2f38865 into develop May 9, 2026
9 checks passed
@tristanlabelle
tristanlabelle deleted the backend/bugfix/push-use-ios_title branch May 9, 2026 23:21
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label May 9, 2026
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed iOS push notifications to show the correct shorter title and subtitle formatting
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes an iOS push notification formatting bug so shorter iOS-specific titles and subtitles are actually shown correctly. It affects how notifications appear to end users on iOS, which is a noticeable user-facing bug fix, though relatively small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants