Skip to content

Fix push and cookie banner covering stuff#8537

Merged
nabramow merged 1 commit into
developfrom
na/web/fix-banners
May 11, 2026
Merged

Fix push and cookie banner covering stuff#8537
nabramow merged 1 commit into
developfrom
na/web/fix-banners

Conversation

@nabramow

Copy link
Copy Markdown
Member

Fixes CookieBanner and PushNotificationBanner so they don't block key stuff in the app.

Closes #8477, Closes #8489

Testing

  • Go in the browser console Application screen, go in localStorage and clear it and also clear cookies
  • Refresh the page, go to landing page and cookie banner should be there
  • Go into mobile view, cookie banner should not block the "Join us" bar at bottom
  • Log in, leave both banners up
  • Go to search, the push notification banner should not block the search bar
  • Close the banners, it should work and go back to normal screen

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 11, 2026 3:00pm

Request Review

@nabramow
nabramow requested a review from jesseallhands May 11, 2026 15:03

@jesseallhands jesseallhands left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on mobile Firefox and chrome. Both work!

@nabramow
nabramow merged commit 2a8b2fb into develop May 11, 2026
8 checks passed
@nabramow
nabramow deleted the na/web/fix-banners branch May 11, 2026 17:30
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label May 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed the cookie and push notification banners so they no longer block important buttons and search controls
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes visible UI bugs where the cookie banner and push notification banner were covering important controls on mobile and search pages. These are noticeable user-facing issues that affect core navigation and usability, so they are worth mentioning in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cookie banner covers up "join us" button on mobile web Push notification banner blocks map search bar

2 participants