Skip to content

Cookie banner should not obscure profile save button#8575

Merged
nabramow merged 2 commits into
developfrom
na/web/fix-cookie-banner-save-profile
May 14, 2026
Merged

Cookie banner should not obscure profile save button#8575
nabramow merged 2 commits into
developfrom
na/web/fix-cookie-banner-save-profile

Conversation

@nabramow

Copy link
Copy Markdown
Member

The cookie banner was obscuring the profile save button and we got a few bug reports about it.

This fixes it so the button appears above the cookie banner.

Testing

Explain how you tested this PR and give clear steps so the reviewer can replicate.

  • Go in the Application screen of the dev console and clear the hasSeenCookieBanner from localStorage
  • Log out, cookie banner should appear
  • Log in and go to edit profile, keeping the cookiebanner up
  • It should be visible
Screenshot 2026-05-14 at 10 40 17 Screenshot 2026-05-14 at 10 40 40

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 14, 2026 0:38am

Request Review

@nabramow
nabramow requested a review from kevinortiz43 May 14, 2026 09:41
@nabramow
nabramow merged commit 07d0a9f into develop May 14, 2026
5 checks passed
@nabramow
nabramow deleted the na/web/fix-cookie-banner-save-profile branch May 14, 2026 12:59
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label May 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed a bug where the cookie banner could cover the profile save button while editing your profile
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes a noticeable bug in a core user flow: on edit profile, the cookie banner could cover the save button and prevent or confuse saving changes. Since it affected users directly and generated bug reports, it is significant enough to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with save button in edit profile being obscured by cookies banner

1 participant