Devex: Add workflow to assign PR reviewers#8601
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
this is okay with me, but can we write the rules in an easy file, and have the actions script read it? that way you don't need to figure out what the script does to update codeowners |
|
@aapeliv The easy way would be to name rules based on the team being assigned, but we'll need a new team for docs changes. Otherwise, I'd have to invent a (yml?) format, since the filters are more complex than CODEOWNERS supports, and delegate to a Python script to parse it. Let me know your preference. |
|
And for the first option, I believe the dorny/path-filters can read its filters from a file so that'd get us pretty close to your request. |
|
Yeah I think you could just come up with a simple syntax, it doesn't need to be complicated. And you can either wrangle the actions script into the required form, or write a python script or similar? If you feel it's too difficult and you're not up for it, maybe we can merge as is too? I just think this is quite hard to modify in the future? |
|
Also we can make a team for translation/docs if you wish |
845673d to
5998396
Compare
|
@aapeliv I found a pretty clean solution, and scoped the workflow to my PRs so I can test it post merge before switching from CODEOWNERS. |
|
@aapeliv (Ready for review) |
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR adds an internal GitHub workflow for automatically assigning code reviewers, which is a developer experience and repository maintenance improvement. It does not affect the product for end users or represent major user-facing technical infrastructure. 🤖 Bot Debug InformationModel: |
This workflow will replace CODEOWNERS and address two issues:
New GitHub workflows are untestable, so this is scoped to
github.event.pull_request.user.login == 'tristanlabelle'. I will test it after merging, then follow up with a PR that switches us from CODEOWNERS.Testing
Will test after merging (currently only targeting PRs of yours truly).
For maintainers