Skip to content

i18n: Remove en-CORP testing language#8610

Merged
tristanlabelle merged 2 commits into
developfrom
i18n/remove-en-corp
May 15, 2026
Merged

i18n: Remove en-CORP testing language#8610
tristanlabelle merged 2 commits into
developfrom
i18n/remove-en-corp

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented May 15, 2026

Copy link
Copy Markdown
Contributor

en-CORP was meant for testing purposes but hasn't been used in the 6 months I've been focusing on i18n, and as part of #8459 I found that its strings were never loaded in the frontend. Per discussion in #8459 (comment) , let's remove that language.

Testing

N/A

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 15, 2026 1:48pm

Request Review

aapeliv
aapeliv previously approved these changes May 15, 2026

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tristanlabelle
tristanlabelle marked this pull request as ready for review May 15, 2026 13:45
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner May 15, 2026 13:45
Comment thread app/backend/src/couchers/i18n/locales/en_CORP.json
@tristanlabelle

Copy link
Copy Markdown
Contributor Author

@aapeliv Now actually published for review (had to fix a test)

@tristanlabelle
tristanlabelle merged commit 5492b99 into develop May 15, 2026
11 checks passed
@tristanlabelle
tristanlabelle deleted the i18n/remove-en-corp branch May 15, 2026 22:44
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR removes an unused internal testing language and related translation files. It does not add or change meaningful functionality for end users, and any visible impact would be negligible since the language was not actually in use.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR removes an unused internal testing language and related translation files. It does not add or change meaningful functionality for end users, and any visible impact would be negligible since the language was not actually in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants