Backend/requests: Fix malformed ics attachment#8646
Merged
tristanlabelle merged 2 commits intoMay 17, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tristanlabelle
marked this pull request as ready for review
May 17, 2026 01:46
kalvdans
approved these changes
May 17, 2026
tristanlabelle
deleted the
backend/bugfix/calendar-events-fix-double-sequence
branch
May 17, 2026 09:16
Contributor
📝 Release NotesThis PR should be included in the release notes. Suggested release note: 🤖 Bot Debug InformationModel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #8635 whereas cancellation ics files would contain both
SEQUENCE:0andSEQUENCE:1, thus interfering with correct cancellation (Gmail wouldn't have it).Testing
Added more testing, but full E2E testing with Gmail requires me merging and using NEXT.
Backend checklist
developif necessary for linear migration historyWeb frontend checklist
For maintainers