Skip to content

Backend/requests: Fix malformed ics attachment#8646

Merged
tristanlabelle merged 2 commits into
developfrom
backend/bugfix/calendar-events-fix-double-sequence
May 17, 2026
Merged

Backend/requests: Fix malformed ics attachment#8646
tristanlabelle merged 2 commits into
developfrom
backend/bugfix/calendar-events-fix-double-sequence

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented May 17, 2026

Copy link
Copy Markdown
Contributor

Fixes a bug introduced in #8635 whereas cancellation ics files would contain both SEQUENCE:0 and SEQUENCE:1, thus interfering with correct cancellation (Gmail wouldn't have it).

Testing

Added more testing, but full E2E testing with Gmail requires me merging and using NEXT.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 17, 2026 1:25am

Request Review

@tristanlabelle
tristanlabelle marked this pull request as ready for review May 17, 2026 01:46
@tristanlabelle
tristanlabelle requested review from a team, WouldYouKindly and aapeliv May 17, 2026 01:47
@tristanlabelle
tristanlabelle merged commit 871e53e into develop May 17, 2026
10 checks passed
@tristanlabelle
tristanlabelle deleted the backend/bugfix/calendar-events-fix-double-sequence branch May 17, 2026 09:16
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label May 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed a bug that prevented cancelled host requests from being properly removed from Google Calendar
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes a user-facing bug affecting host request calendar cancellations in Gmail/Google Calendar, which is noticeable and important for people relying on calendar email attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants