Default notification email feature flags to off#8792
Merged
aapeliv merged 1 commit intoMay 24, 2026
Conversation
The notification_translations_enabled and email_ics_attachments_enabled flags were defaulting to True, leaving both features on when the flag is absent. Default them to False to match every other feature gate.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 Release NotesThis PR does not need to be included in release notes. Reason: This is a small internal configuration fix for notification email feature flags. It does not introduce a new user-facing feature, noticeable UX change, or major infrastructure improvement that end users would care about in release notes. 🤖 Bot Debug InformationModel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8783 migrated
ENABLE_NOTIFICATION_TRANSLATIONSandENABLE_EMAIL_ICS_ATTACHMENTSfrom env config to GrowthBook feature flags, but evaluated both withdefault=True. That leaves both features ON whenever the flag is absent from GrowthBook (or experimentation is disabled), whereas every other feature gate in the codebase (sms_enabled,donations_enabled,strong_verification_enabled,postal_verification_enabled,recaptcha_enabled) defaults toFalse. This flipsnotification_translations_enabledandemail_ics_attachments_enabledtodefault=Falseso the features are off unless explicitly enabled.Testing
uv run pytest src/tests/test_calendar_events.pypasses (4/4). The existing attachment test still produces attachments because normal tests run withEXPERIMENTATION_PASS_ALL_GATES=True, and the new disabled-test forces the flag off explicitly.Backend checklist
developif necessary for linear migration historyFor maintainers
This PR was created with the Couchers PR skill.