Skip to content

Default notification email feature flags to off#8792

Merged
aapeliv merged 1 commit into
developfrom
backend/bugfix/notification-email-flags-default-off
May 24, 2026
Merged

Default notification email feature flags to off#8792
aapeliv merged 1 commit into
developfrom
backend/bugfix/notification-email-flags-default-off

Conversation

@aapeliv

@aapeliv aapeliv commented May 24, 2026

Copy link
Copy Markdown
Member

PR #8783 migrated ENABLE_NOTIFICATION_TRANSLATIONS and ENABLE_EMAIL_ICS_ATTACHMENTS from env config to GrowthBook feature flags, but evaluated both with default=True. That leaves both features ON whenever the flag is absent from GrowthBook (or experimentation is disabled), whereas every other feature gate in the codebase (sms_enabled, donations_enabled, strong_verification_enabled, postal_verification_enabled, recaptcha_enabled) defaults to False. This flips notification_translations_enabled and email_ics_attachments_enabled to default=False so the features are off unless explicitly enabled.

Testing

  • uv run pytest src/tests/test_calendar_events.py passes (4/4). The existing attachment test still produces attachments because normal tests run with EXPERIMENTATION_PASS_ALL_GATES=True, and the new disabled-test forces the flag off explicitly.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

This PR was created with the Couchers PR skill.

The notification_translations_enabled and email_ics_attachments_enabled
flags were defaulting to True, leaving both features on when the flag is
absent. Default them to False to match every other feature gate.
@vercel

vercel Bot commented May 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Building Building Preview May 24, 2026 5:46pm

Request Review

@aapeliv
aapeliv merged commit af56f58 into develop May 24, 2026
4 of 6 checks passed
@aapeliv
aapeliv deleted the backend/bugfix/notification-email-flags-default-off branch May 24, 2026 17:47
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This is a small internal configuration fix for notification email feature flags. It does not introduce a new user-facing feature, noticeable UX change, or major infrastructure improvement that end users would care about in release notes.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This is a small internal configuration fix for notification email feature flags. It does not introduce a new user-facing feature, noticeable UX change, or major infrastructure improvement that end users would care about in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant