Clean up native OTA manifest endpoint (rename RPC, simplify header reads)#8796
Merged
Conversation
…r reads Follow-up cleanups to #8791: rename the RPC from GetMobileUpdateManifest to GetNativeUpdateManifest for consistency with the /native/ota/manifest route, and drop the per-RPC header helper (the bytes branch was dead code, since the expo-* headers are never binary metadata) in favour of reading context.headers directly, matching the convention elsewhere. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR is explicitly a cleanup with no behavior change: it renames an internal RPC, simplifies internal header handling, and updates tests/docs. It is not user-visible and does not represent a major technical improvement that end users would notice. 🤖 Bot Debug InformationModel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanups to #8791 (already merged).
Summary
GetMobileUpdateManifest→GetNativeUpdateManifest, for consistency with the/native/ota/manifestroute.header()helper: itsbytesbranch was dead code (theexpo-*headers are never binary gRPC metadata), so readcontext.headersdirectly with acast(str, ...), matching the convention inauth.py.No behaviour change to the endpoint.
Test plan
pytest src/tests/test_bugs.py(18 passed)make formatclean