Skip to content

Add exclude attending and organizing from my communities events#9031

Merged
nabramow merged 8 commits into
developfrom
na/backend/add-exclude-attending
Jun 21, 2026
Merged

Add exclude attending and organizing from my communities events#9031
nabramow merged 8 commits into
developfrom
na/backend/add-exclude-attending

Conversation

@nabramow

@nabramow nabramow commented Jun 7, 2026

Copy link
Copy Markdown
Member

We already have attending and organizing as boolean params to the ListMyEvents query, but when my_communities=true it overrides it if the events we're attending or organizing are in our communities.

Therefore I'm adding exclude_attending for this, to try and make it as backward compatible as possible.

Testing

Explain how you tested this PR and give clear steps so the reviewer can replicate.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@nabramow
nabramow requested a review from aapeliv as a code owner June 7, 2026 18:12
@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview Jun 8, 2026 11:07am

Request Review

@CouchersBot

CouchersBot commented Jun 7, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F96d0fe1f--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F96d0fe1f--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

Comment thread app/backend/src/couchers/servicers/events.py Outdated
@nabramow

Copy link
Copy Markdown
Member Author

@aapeliv I've addressed your comments now!

Comment thread app/backend/src/couchers/servicers/events.py Outdated
Comment thread app/backend/src/couchers/servicers/events.py Outdated
@nabramow
nabramow merged commit 2636eb3 into develop Jun 21, 2026
5 checks passed
@nabramow
nabramow deleted the na/backend/add-exclude-attending branch June 21, 2026 09:13
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This changes backend filtering for the 'My Events' query so community event lists can exclude events the user is already attending or organizing. While it affects event discovery behavior, the PR does not show a corresponding user-facing UI change and appears to be a relatively small API/filtering fix rather than a broadly noticeable feature or major bug fix.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This changes backend filtering for the 'My Events' query so community event lists can exclude events the user is already attending or organizing. While it affects event discovery behavior, the PR does not show a corresponding user-facing UI change and appears to be a relatively small API/filtering fix rather than a broadly noticeable feature or major bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants