Skip to content

Backend/notifs: Remove deprecated notification_data.ChatMessage.message - #9118

Merged
tristanlabelle merged 4 commits into
developfrom
backend/refactor/notifs-remove-ChatMessage.message
Jun 14, 2026
Merged

Backend/notifs: Remove deprecated notification_data.ChatMessage.message#9118
tristanlabelle merged 4 commits into
developfrom
backend/refactor/notifs-remove-ChatMessage.message

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

It was kept as a fallback in #8753 (merged 2026-05-26) because we might still have been processing jobs referencing ChatMessage instances with a message value. I think it's safe to assume those have drained by now.

Testing

Updated the test that used this field. Otherwise no test covered the deprecated code path.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 14, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fa53d30a4--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fa53d30a4--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review June 14, 2026 17:58
@tristanlabelle
tristanlabelle merged commit 94a283b into develop Jun 14, 2026
5 checks passed
@tristanlabelle
tristanlabelle deleted the backend/refactor/notifs-remove-ChatMessage.message branch June 14, 2026 17:58
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR removes deprecated backend fallback code and reserves an old proto field after previous migration work. It is an internal cleanup with no new user-facing feature, noticeable UX change, or significant end-user impact on its own.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR removes deprecated backend fallback code and reserves an old proto field after previous migration work. It is an internal cleanup with no new user-facing feature, noticeable UX change, or significant end-user impact on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants