Skip to content

Frontend/search: Show strong verif badges#9160

Merged
tristanlabelle merged 4 commits into
developfrom
frontend/feature/search-strong-verif-badge
Jun 25, 2026
Merged

Frontend/search: Show strong verif badges#9160
tristanlabelle merged 4 commits into
developfrom
frontend/feature/search-strong-verif-badge

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

We forgot to show the strong verification badge in search results, where it's quite useful.

Testing

Since NEXT doesn't have strong verified users, I injected user.hasStrongVerification = true for testing:

image

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 22, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Ffcfd5b95--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Ffcfd5b95--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review June 22, 2026 02:22
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner June 22, 2026 02:22
@tristanlabelle
tristanlabelle requested a review from a team June 22, 2026 02:22
Comment thread app/web/features/search/SeachResultUserCard.tsx Outdated
@nabramow

nabramow commented Jun 22, 2026

Copy link
Copy Markdown
Member

@tristanlabelle I think we need to align it with the name vertically so they are centered? The badge seems higher than the text.

Screenshot 2026-06-22 at 16 42 09

btw both Aapeli and I have strong verification badges on next if you query in NYC or London!

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

The way I have it looks exactly the same as on the profile page (verified by overlapping the screenshots). Does it look off to you on the profile page as well? If so it might be a separate change.

@nabramow

Copy link
Copy Markdown
Member

The way I have it looks exactly the same as on the profile page (verified by overlapping the screenshots). Does it look off to you on the profile page as well? If so it might be a separate change.

Yeah same on the profile page. It's more obvious in this image where you can see it falls in the top of the box:

Screenshot 2026-06-22 at 20 55 57

Comment thread app/web/features/profile/view/UserOverview.tsx Outdated
Comment thread app/web/features/search/SeachResultUserCard.tsx Outdated
@tristanlabelle

tristanlabelle commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@nabramow It looks worse with display: inline-block; vertical-align: middle;. I think it makes sense that the icon sits on the text baseline as it currently does.

image

font-size: 90% makes it more the size of the text, if you like that better.

image

But I'd like a ✅ for the fix I'm implemented in all cases.

@nabramow

Copy link
Copy Markdown
Member

@nabramow It looks worse with display: inline-block; vertical-align: middle;. I think it makes sense that the icon sits on the text baseline as it currently does.

image `font-size: 90%` makes it more the size of the text, if you like that better. image But I'd like a ✅ for the fix I'm implemented in all cases.

Such is frontend work, I'm afraid. Would you like me to push the change to your branch? Generally you fix this by wrapping both in a box and centering them.

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

Would you like me to push the change to your branch?

I would rather we merge this and let you follow up with the visual tweak, but otherwise go ahead.

@nabramow nabramow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in some changes to do the style the more proper react way. If you're cool with it go ahead and merge, I tested all the components with changes to check they look okay.

@tristanlabelle
tristanlabelle merged commit 4cba89b into develop Jun 25, 2026
4 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/feature/search-strong-verif-badge branch June 25, 2026 10:48
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Fixed search results to show strong verification badges so members can more easily spot strongly verified users
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This fixes a missing strong verification badge in search results, which is a visible and useful trust/safety signal for users when browsing profiles. It is a noticeable user-facing bug fix tied to safety and decision-making in search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants