Skip to content

Frontend: link "Pending" friend-request button to My Connections#9181

Merged
tristanlabelle merged 2 commits into
developfrom
claude/issue-9130-20260625-1224
Jun 26, 2026
Merged

Frontend: link "Pending" friend-request button to My Connections#9181
tristanlabelle merged 2 commits into
developfrom
claude/issue-9130-20260625-1224

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

When visiting the profile page of user who sent you a friend request, the "pending" button now sends you to My Connections and scrolls to the request of interest.

Resolves #9130.

With help from Claude Code

Testing

Ran local frontend. Made my browser window tiny to observe the scrolling effect.

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

Clicking the "Pending" button on a profile now navigates to the My
Connections page with a `?friend-id=<userId>` query param instead of
opening an inline accept/dismiss menu, so the user can respond there
and review other open requests.

The connections page reads `friend-id` (renamed from the unused `from`
param added in #9042) to detect the targeted request, shows the
existing "no longer available" alert when it's gone, and now smoothly
scrolls the matching request card into view.

Co-authored-by: Tristan Labelle <tristanlabelle@users.noreply.github.com>
@CouchersBot

CouchersBot commented Jun 25, 2026

Copy link
Copy Markdown
Member

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review June 25, 2026 13:19
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner June 25, 2026 13:19
@tristanlabelle
tristanlabelle requested review from a team and jesseallhands June 25, 2026 13:19
@nabramow

Copy link
Copy Markdown
Member

@tristanlabelle Wanna send me a friend request to my stage account so I can see it? Username is @nabramow on staging.

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

@nabramow Sent you a friend request on NEXT! Protip: That's why I have tristanlabelle and tristanlabelle2 :)

@jesseallhands jesseallhands left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nabramow nabramow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tristanlabelle
tristanlabelle merged commit 4a8f7b9 into develop Jun 26, 2026
9 checks passed
@tristanlabelle
tristanlabelle deleted the claude/issue-9130-20260625-1224 branch June 26, 2026 14:28
@github-actions github-actions Bot added the release notes: pending Add to stuff that should be included in release notes label Jun 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Improved the Pending friend request button so it takes you to My Connections and jumps to the relevant request
🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This is a small but user-facing UX improvement: when viewing someone who sent you a friend request, the Pending button now takes you to My Connections and jumps to that request so you can respond there more easily. It's noticeable to users, but not a major feature; still worth including as a useful workflow improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: pending Add to stuff that should be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Friend request "Pending" button should link to the My Connections page

4 participants