Skip to content

Frontend: Fix duplicate edit profile button#9191

Merged
tristanlabelle merged 1 commit into
developfrom
frontend/bugfix/remove-duplicate-edit-profile-button
Jun 27, 2026
Merged

Frontend: Fix duplicate edit profile button#9191
tristanlabelle merged 1 commit into
developfrom
frontend/bugfix/remove-duplicate-edit-profile-button

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

The edit profile button was mysteriously duplicated in #8317, with a bad string key too. Also the dashboard string was unreferenced.

Testing

After fix:

image

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 27, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc1b00566--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc1b00566--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review June 27, 2026 20:34
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner June 27, 2026 20:34
@tristanlabelle
tristanlabelle requested a review from a team June 27, 2026 20:34

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. maybe a broken merge when the translation keys changed?

@tristanlabelle
tristanlabelle merged commit bd1ab6f into develop Jun 27, 2026
8 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/bugfix/remove-duplicate-edit-profile-button branch June 27, 2026 23:43
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR fixes a minor UI bug where the edit profile button appeared twice in a dialog and removes an unused translation string. While visible, it is a small polish fix rather than a significant user-facing improvement or important bug fix affecting core functionality.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR fixes a minor UI bug where the edit profile button appeared twice in a dialog and removes an unused translation string. While visible, it is a small polish fix rather than a significant user-facing improvement or important bug fix affecting core functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants