Skip to content

Backend/emails: Take links out of loc files.#9192

Merged
tristanlabelle merged 3 commits into
developfrom
backend/refactor/emails-links-nonloc
Jun 30, 2026
Merged

Backend/emails: Take links out of loc files.#9192
tristanlabelle merged 3 commits into
developfrom
backend/refactor/emails-links-nonloc

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Having html links in loc strings introduces risks that translators make mistakes with the syntax, and makes it more difficult to modify the URLs. It's more maintainable to interpolate the links from the code.

Testing

Checked at generated emails on this PR:

image

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 27, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb3f08c21--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb3f08c21--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

Comment thread app/backend/src/couchers/email/blocks.py Outdated

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Comment thread app/backend/src/couchers/email/emails.py Outdated
@tristanlabelle

Copy link
Copy Markdown
Contributor Author

Fixed email address and rebased. Merging based on "lgtm otherwise"

@tristanlabelle
tristanlabelle merged commit 6805ce6 into develop Jun 30, 2026
4 checks passed
@tristanlabelle
tristanlabelle deleted the backend/refactor/emails-links-nonloc branch June 30, 2026 15:47
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is an internal maintainability refactor for email localization and link handling. It does not add new user-facing functionality or fix a noticeable bug for end users, and the impact is mainly reducing translator error risk in the codebase.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is an internal maintainability refactor for email localization and link handling. It does not add new user-facing functionality or fix a noticeable bug for end users, and the impact is mainly reducing translator error risk in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants