Skip to content

Events: Rename EventOfflineInformation to EventLocation#9205

Merged
tristanlabelle merged 1 commit into
developfrom
both/refactor/events-EventLocation
Jun 30, 2026
Merged

Events: Rename EventOfflineInformation to EventLocation#9205
tristanlabelle merged 1 commit into
developfrom
both/refactor/events-EventLocation

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #9133 . Since we don't have online events anymore, we can rename EventOfflineInformation to the more descriptive EventLocation. This is safe as names are not part of the serialized protobuf format.

Testing

Ran linting+mypy

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 29, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F9ba39673--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F9ba39673--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle tristanlabelle changed the title Events: Rename OfflineInformation to EventLocation Events: Rename EventOfflineInformation to EventLocation Jun 29, 2026
@tristanlabelle
tristanlabelle marked this pull request as ready for review June 29, 2026 23:03
@tristanlabelle
tristanlabelle requested a review from a team June 29, 2026 23:03

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on backend side as it's just a rename

@tristanlabelle
tristanlabelle merged commit dfbedb1 into develop Jun 30, 2026
9 checks passed
@tristanlabelle
tristanlabelle deleted the both/refactor/events-EventLocation branch June 30, 2026 13:12
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is an internal rename of event location fields and protobuf messages after online events were already removed in an earlier PR. It does not introduce a new user-facing feature or noticeable behavior change, and the backcompat notes indicate it is safe internal cleanup rather than a significant technical improvement for users.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is an internal rename of event location fields and protobuf messages after online events were already removed in an earlier PR. It does not introduce a new user-facing feature or noticeable behavior change, and the backcompat notes indicate it is safe internal cleanup rather than a significant technical improvement for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants