Frontend/i18n: Remove inline <Trans> text

[tristanlabelle]

Our <Trans> tags often included a copy of the string from en.json, which unavoidably lead to the two drifting apart as noted in #9008. It turns out we don't have to do that and can simply provide the components to be instantiated by the string without duplicating the text.

Closes #9008

Testing

Used vercel preview to spot check:

ProfileIncompleteDialog

StrongVerificationPage (note the text is from the more recent en.json, the inline text was stale)

PushNotificationSetting

Web frontend checklist

• There are no console warnings when running the app
• Added tests where relevant
• Clicked around my changes running locally and it works
• Checked Desktop, Mobile and Tablet screen sizes

For maintainers

• Maintainers can push commits to my branch
• Maintainers can merge this PR for me

[CouchersBot]

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

iOS	Android
Open in Dev Tool	Open in Dev Tool

Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F16364614--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F16364614--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema	Schema diff	Sample emails

Other

Protos	Backend coverage	Web coverage

[nabramow]

Oh great, I always thought this seemed a bit weird! I tested a couple and seems okay to me!

[github-actions]

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is primarily an internal i18n/code cleanup that removes duplicated inline translation text and aligns the frontend with existing translation strings. While it may fix a few stale wording mismatches, it does not introduce a new user-facing feature or a significant end-user-visible bug fix on its own.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is primarily an internal i18n/code cleanup that removes duplicated inline translation text and aligns the frontend with existing translation strings. While it may fix a few stale wording mismatches, it does not introduce a new user-facing feature or a significant end-user-visible bug fix on its own.