Block incomplete profiles from commenting on all threads

[kevinortiz43]

Generalizes the incomplete-profile comment gate from event-only to all threads. A user with an incomplete profile (no photo, or fewer than 150 characters in "about me") can no longer post a comment or reply on any thread — events, community discussions, groups, guides, or places — and is shown the existing ProfileIncompleteDialog prompting them to complete their profile. This replaces the earlier event-scoped, opt-in version of this gate.

How it works

Comments are a single shared mechanism: every comment box posts via the shared Threads.PostReply RPC. The gate is enforced on both layers:

• Backend (trust boundary): PostReply now calls has_completed_profile unconditionally and aborts FAILED_PRECONDITION / incomplete_profile_post_comment for any thread. The old event-only _is_event_thread reverse-lookup is deleted. Mirrors the CreateEvent / CreateHostRequest / CreateDiscussion pattern (a single choke point).
• Frontend: both comment components — CommentForm (discussion/event comments + replies) and NewComment (group/guide/place CommentBox) — check accountInfo.profileComplete and open ProfileIncompleteDialog with a generic attempted_action="post_comment" ("post a comment") instead of the event-specific copy. The opt-in attemptedAction plumbing through CommentTree/EventPage is removed.

Also included

• Push-notification banner fix carried on this branch: removes a negative top margin on PageHeader that pulled the full-bleed map up over the banner on Community/Discussion pages.

Testing

• Backend: ruff format --check + ruff check clean; mypy verified clean on the change; pytest src/tests/test_threads.py — 22 passed, including the new/updated cases: incomplete profile blocked on an event comment, on an event reply, and on a discussion thread (proving the gate is no longer event-scoped), plus complete profile allowed.
• Frontend: yarn format clean; tsc --noEmit introduces no new errors. New CommentForm gate tests: incomplete profile opens the dialog and does not call postReply; complete profile posts. Web unit tests (jest) run in CI — the local jest env is currently broken (next/jest resolution), so they were not run on this machine.
• Manual, against a preview backend / local stack:
  • Complete profile (local backend running this branch): created a discussion and posted a comment — CreateDiscussion + PostReply both 200, comment persisted, no dialog.
  • Incomplete profile (online, desktop): discussion comment and event comment both show the dialog ("Before you can post a comment, you must write a bit about yourself … upload a profile photo") and send no PostReply.
  • Incomplete profile (Android emulator, WebView): discussion comment shows the same dialog, renders correctly on mobile, no comment posted.

Backend checklist

• Added tests for any new code or added a regression test if fixing a bug
• Run the backend locally and it works
• Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

• There are no console warnings when running the app
• Added tests where relevant
• Clicked around my changes running locally and it works
• Checked Desktop, Mobile and Tablet screen sizes

For maintainers

• Maintainers can push commits to my branch
• Maintainers can merge this PR for me

This PR was created with the Couchers PR skill.

[CouchersBot]

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

iOS	Android
Open in Dev Tool	Open in Dev Tool

Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc2c385ec--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc2c385ec--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema	Schema diff	Sample emails

Other

Protos	Backend coverage	Web coverage

[aapeliv]

What is the motivation for this change? Sorry I don't remember.

I'm not sure why we have an exception for events: why not implement for all threads? Also I feel like empty profiles posting on events is not much of an issue (it may get people to join, then complete profile later)?

[nabramow]

What is the motivation for this change? Sorry I don't remember.

I'm not sure why we have an exception for events: why not implement for all threads? Also I feel like empty profiles posting on events is not much of an issue (it may get people to join, then complete profile later)?

We talked about it at the last meeting and Nick said moderation-wise he felt it was an issue so we decided to do it.

I might have missed something re: threads. Are you saying to do the logic upstream?

[kevinortiz43]

@aapeliv In my research we can implement it for all threads, but the specific task was to "only prevent from commenting on events" since we already had another story to prevent commenting on discussions. So you want it prevented for any type of comments?

[kevinortiz43]

@aapeliv would you like to me implement this for all threads?

[kevinortiz43]

Block on all threads suggestion by Aapeli on 7/10/2026 during Couchers stand up

[nabramow]

Hey @kevinortiz43 just a tip for the future to help your PRs get reviewed faster as I'm noticing a trend. The description, etc. looks very AI-heavy, lots of jargon and hard to read, and feels like a wall of text at first open, more text than needed for something simple like this, which makes it overwhelming. Please keep your human readers in mind!

Try to put it in your own words in the future, make sure you understand what AI did, and keep it more in the tone of "what does the reviewer actually need to know to review this?", why you made certain decisions, etc.

Otherwise it puts the burden on the reviewer to parse through everything and figure out what's going on, and when we see something very AI-heavy, it doesn't elicit trust that you know what's going on, which makes it feel like we need to have extra attention to detail when reviewing, which also takes more time.

[kevinortiz43]

@nabramow understood I will rework the description of my pull requests. I have a few open ones right now would you like me to rework the descriptions and resubmit them?

[nabramow]

@nabramow understood I will rework the description of my pull requests. I have a few open ones right now would you like me to rework the descriptions and resubmit them?

That would be great if you don't mind!

[kevinortiz43]

@nabramow can do, also regarding the sunflower drop, I believe the deadline for that is tomorrow. I will get the PR descriptions fixed by then but I did want to move fast to try and meet the deadline. Should we move that deadline to the right? or are we going to speak more about it on Friday?

[nabramow]

@nabramow can do, also regarding the sunflower drop, I believe the deadline for that is tomorrow. I will get the PR descriptions fixed by then but I did want to move fast to try and meet the deadline. Should we move that deadline to the right? or are we going to speak more about it on Friday?

It's okay we can just miss the deadline as long as we get it around that time. I also won't be able to attend this meeting Friday as I'll be on a canoe trip 😅.

[kevinortiz43]

@nabramow that sounds so fun! I hope you have a great time!

[nabramow]

Alright this seems okay to me, I've also clicked around and tested discussions and events comments with and without a profile.

[github-actions]

📝 Release Notes

This PR should be included in the release notes.

Suggested release note:

Required users to complete their profile before posting comments or replies anywhere on the platform

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: include
Reasoning: This change is user-facing and significant: it expands an existing profile-completion requirement so users must complete their profile before commenting anywhere on the platform, which affects discussions, events, groups, guides, and places. It also supports moderation and community quality, making it relevant for release notes. The banner layout fix is minor and not the main reason to include it.