Skip to content

clarify that username is public#9261

Merged
nabramow merged 3 commits into
developfrom
nick/usernameispublic
Jul 15, 2026
Merged

clarify that username is public#9261
nabramow merged 3 commits into
developfrom
nick/usernameispublic

Conversation

@nc225

@nc225 nc225 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Describe briefly what this PR is doing and why.
clarifying that username is public and different from profile name
closes #4145 and #8684

Testing

checked text
Web frontend checklist

  • [X ] There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@nc225
nc225 requested a review from nabramow as a code owner July 10, 2026 13:35
@CouchersBot

CouchersBot commented Jul 10, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc0b0ef2d--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fc0b0ef2d--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@nabramow

Copy link
Copy Markdown
Member

@nc225 Is the profile name helper text supposed to show here?

Screenshot 2026-07-14 at 09 49 56

@nc225

nc225 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@nabramow No, I believe that box is for the user's profile/display name. It should show on the next page when creating username

@nabramow

Copy link
Copy Markdown
Member

@nabramow No, I believe that box is for the user's profile/display name. It should show on the next page when creating username

The username one is fine. I'm talking about this change:

"helper_text": "This is your profile name."

Where should that be visible?

@nc225

nc225 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@nabramow Hmm good point. I'm not sure where that ones comes in, maybe in Edit Profile? In any case, I had included that part since I had thought the username/name were on the same screen, but since they're not how about we drop the name helper_text and keep the username helper_text. Shall I submit a new PR?

@nabramow

Copy link
Copy Markdown
Member

@nabramow Hmm good point. I'm not sure where that ones comes in, maybe in Edit Profile? In any case, I had included that part since I had thought the username/name were on the same screen, but since they're not how about we drop the name helper_text and keep the username helper_text. Shall I submit a new PR?

You don't need to submit a new PR, I'd just remove that line from this one if we're not sure where it should go!

@nabramow nabramow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@nabramow
nabramow merged commit bb86e18 into develop Jul 15, 2026
5 checks passed
@nabramow
nabramow deleted the nick/usernameispublic branch July 15, 2026 13:25
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR only changes helper text to clarify that usernames are public, which is a minor copy/UI clarification rather than a significant user-facing feature, major UX improvement, or important bug fix.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR only changes helper text to clarify that usernames are public, which is a minor copy/UI clarification rather than a significant user-facing feature, major UX improvement, or important bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add helper text to "username" text field during signup

3 participants