Skip to content

Frontend: More dayjs -> Temporal migration#9282

Merged
tristanlabelle merged 4 commits into
developfrom
frontend/refactor/more-dayjs-to-Temporal
Jul 19, 2026
Merged

Frontend: More dayjs -> Temporal migration#9282
tristanlabelle merged 4 commits into
developfrom
frontend/refactor/more-dayjs-to-Temporal

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
  • Migrate misc code still using dayjs to Temporal.
  • Abstract dayjs' "humanize" api behind localizeDuration for consistency and so we can switch to browser APIs in the future.
  • Extract spreading a duration's units into approximate date units and back (approxTimeDuration + approxDateDuration)
  • Add more tests

There are still some public trip-related code using dayjs but I don't know how to test that so I didn't touch it.

Testing

Compared vercel preview and next: host requests, last active, local time, upcoming trips+stays on dashboard. Saw no difference.

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jul 15, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb51f5c7e--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2Fb51f5c7e--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review July 16, 2026 20:27
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner July 16, 2026 20:27
@tristanlabelle
tristanlabelle requested a review from a team July 16, 2026 20:27
Comment thread app/web/utils/date.ts
Comment thread app/web/utils/date.ts
Comment thread app/web/features/messages/groupchats/MuteDialog.tsx
nabramow
nabramow previously approved these changes Jul 19, 2026

@nabramow nabramow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit with the comment, otherwise everything seems to work as before!

@tristanlabelle
tristanlabelle merged commit b8ce1c3 into develop Jul 19, 2026
8 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/refactor/more-dayjs-to-Temporal branch July 19, 2026 13:34
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is primarily an internal frontend refactor migrating date handling from dayjs to Temporal, with added abstractions and tests. The author explicitly noted that tested user flows showed no visible difference, and the changes do not introduce a new feature or a clearly noticeable bug fix for end users. While it may improve code consistency and future maintainability, it does not rise to the level of major technical infrastructure work that should appear in release notes.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is primarily an internal frontend refactor migrating date handling from dayjs to Temporal, with added abstractions and tests. The author explicitly noted that tested user flows showed no visible difference, and the changes do not introduce a new feature or a clearly noticeable bug fix for end users. While it may improve code consistency and future maintainability, it does not rise to the level of major technical infrastructure work that should appear in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants