Skip to content

Frontend/notifs/i18n: Improve filters string keys#9309

Open
tristanlabelle wants to merge 1 commit into
developfrom
frontend/bugfix/all-unread-notifs-strings
Open

Frontend/notifs/i18n: Improve filters string keys#9309
tristanlabelle wants to merge 1 commit into
developfrom
frontend/bugfix/all-unread-notifs-strings

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

"unread" is ambiguous as to number and gender, so some translations were incorrect. Add more context to the string keys and force relocalization.

"notifications" in the string key is not strictly needed since the component is about notifications, but this isn't the most obvious in weblate so it doesn't hurt to be a little redundant.

Testing

Vercel preview is not broken

image

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jul 22, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F99238763--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F99238763--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review July 22, 2026 20:04
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner July 22, 2026 20:04
@tristanlabelle
tristanlabelle requested a review from a team July 22, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants