Don't send community event invites to users already attending#9310
Open
nabramow wants to merge 2 commits into
Open
Don't send community event invites to users already attending#9310nabramow wants to merge 2 commits into
nabramow wants to merge 2 commits into
Conversation
Member
MobileInstall the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here. Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.
Deep linksiOS Android Web (Vercel)View the Vercel web preview for this branch. Backend
Other
|
aapeliv
requested changes
Jul 23, 2026
aapeliv
left a comment
aapeliv
left a comment
Member
There was a problem hiding this comment.
i think when we made this, we were thinking it would be helpful for the organizer to see what the email looked like
| logger.error(f"Inviting user {payload.inviting_user_id} is gone while trying to send event notification?") | ||
| return | ||
|
|
||
| # people already attending or organizing the event don't need an invite to it |
Member
There was a problem hiding this comment.
let's move this into get_users_to_notify_for_new_event; and do it in that single SQL query; instead of adding two more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Couchers-org/bugs#99.
When an editor approves a community invite for an event, the notification fan-out (
generate_event_create_notifications) notified every visible community member, including people who had already RSVP'd and the event's organizers.Now attendees of the occurrence and organizers of the event are excluded; subscribers (followers who haven't RSVP'd) still receive the invite. Added a test covering the reported scenario (RSVP before the invite is approved).
Testing
Explain how you tested this PR and give clear steps so the reviewer can replicate.
Backend checklist
developif necessary for linear migration historyFor maintainers