Skip to content

Backend: Remove str-based EventUpdate items#9320

Merged
tristanlabelle merged 2 commits into
developfrom
claude/issue-9117-20260723-2134
Jul 25, 2026
Merged

Backend: Remove str-based EventUpdate items#9320
tristanlabelle merged 2 commits into
developfrom
claude/issue-9117-20260723-2134

Conversation

@tristanlabelle

Copy link
Copy Markdown
Contributor

Removes the deprecated updated_str_items field from both the EventUpdate notification data message and the GenerateEventUpdateNotificationsPayload internal job payload, reserving the field numbers and names. The i18n-friendly updated_enum_items field is now the sole source.

(a month has passed since I migrated us over so it should be safe that there are no old queued jobs using updated_str_items anymore.)

Fixes #9117

Generated with Claude Code

github-actions Bot and others added 2 commits July 23, 2026 21:38
Removes the deprecated updated_str_items field from both the EventUpdate
notification data message and the GenerateEventUpdateNotificationsPayload
internal job payload, reserving the field numbers and names so they can
never be reused. The i18n-friendly updated_enum_items field is now the
sole source. Also drops the now-unused _updated_item_str_to_enum helper.

Fixes #9117

Co-authored-by: Tristan Labelle <2314287+tristanlabelle@users.noreply.github.com>
@tristanlabelle tristanlabelle changed the title Remove str-based EventUpdate items Backend: Remove str-based EventUpdate items Jul 23, 2026
@CouchersBot

CouchersBot commented Jul 23, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F235d7f27--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F235d7f27--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review July 24, 2026 11:08
@tristanlabelle
tristanlabelle requested a review from aapeliv as a code owner July 24, 2026 11:08
@tristanlabelle
tristanlabelle requested a review from a team July 24, 2026 11:08
Comment thread app/proto/notification_data.proto
@tristanlabelle
tristanlabelle requested a review from a team July 25, 2026 15:38
@tristanlabelle
tristanlabelle merged commit 6b537dc into develop Jul 25, 2026
13 checks passed
@tristanlabelle
tristanlabelle deleted the claude/issue-9117-20260723-2134 branch July 25, 2026 21:54
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR removes deprecated backend/internal notification fields and cleanup code after a migration. It does not add or change any noticeable user-facing behavior, and the technical work is routine maintenance rather than a major infrastructure or reliability improvement worth highlighting to end users.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR removes deprecated backend/internal notification fields and cleanup code after a migration. It does not add or change any noticeable user-facing behavior, and the technical work is routine maintenance rather than a major infrastructure or reliability improvement worth highlighting to end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend/events: Remove str-based EventUpdated items

3 participants