chore: Upgrade MUI to v9#9321
Draft
darrenvong wants to merge 4 commits into
Draft
Conversation
it's rarely good to do an `as unknown as T` assert, as you're basically side-stepping TS in an unsafe way
Member
Web (Vercel)View the Vercel web preview for this branch. Other
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe briefly what this PR is doing and why.
Closes #9132
Relevant changes made from following the migration guide:
@mui/material/icons-material/system/utils→ 9.2.0,material-nextjs→ 9.1.1,@mui/lab→ 9.0.0-beta.6,x-date-pickers→ 9.10.0.InputProps/inputProps→slotProps: TextFieldInputProps=→slotProps={{ input }}; Autocompleteparams.InputProps→params.slotProps.input,params.inputProps→params.slotProps.htmlInput.slotProps:slotProps.textField.InputProps→slotProps.textField.slotProps.input;PickersDayremoval/rename (PickerDay2→PickersDay).primaryTypographyProps→slotProps.primary.sx.Testing
Explain how you tested this PR and give clear steps so the reviewer can replicate.
Here's the manual smoke test list I've been going through based on the pages with changed code as a result of this upgrade:
/search (highest value)
slotProps.inputmigration)/signup (account form step)
pickerInputOnly+PickersDayremoval in pickers v9)/profile/edit
params.slotPropsfix)/dashboard
primaryTypographyProps→slotProps.primary)ChatBubbleOutlined)/communities
params.InputPropsmigration)/account-settings/notifications
MailOutlined)ListItemIconmin-width dropped 56px → 36px) [This definitely reduced the gap between icon and label, but still looks reasonable to me so ok to keep probably?]/what-is-couch-surfing
CheckCircleOutlined)ListItemIconpage)Events
slotPropsmigration)Host requests / trips
/messages
Leave reference flow
Behavior-change checks (no code edits, v9 runtime changes)
MenuItemrenders outsideMenu/MenuList, so crashes would surface immediatelyaria-hidden)Backend checklist
developif necessary for linear migration historyWeb frontend checklist
For maintainers