Backend/events: Add GetEventCalendarFile API#9326
Open
tristanlabelle wants to merge 9 commits into
Open
Conversation
Member
Web (Vercel)View the Vercel web preview for this branch. Backend
Other
|
aapeliv
requested changes
Jul 25, 2026
aapeliv
left a comment
aapeliv
left a comment
Member
There was a problem hiding this comment.
lgtm but let's keep the to_aware_datetime function simple
Comment on lines
+118
to
+120
| if isinstance(timezone, str): | ||
| timezone = ZoneInfo(timezone) | ||
| return ts.ToDatetime(tzinfo=timezone) |
Member
There was a problem hiding this comment.
let's keep this function as a clean "protobuf object -> instant of time" function. we can do the conversion elsewhere or have another helper, but it is non-intuitive to many (including myself) what it means to pass in a timzone into this function; as this function is converting "naive" timestamps into "aware" ones. so let's keep it dumb and do the presentation semantics elsewhere.
|
|
||
| // TODO: DownloadCalendarInvite | ||
| rpc GetEventCalendarFile(GetEventCalendarFileReq) returns (GetEventCalendarFileRes) { | ||
| // Downloads a calendar file for an event |
Member
There was a problem hiding this comment.
if you want to eventually use this as a pure HTTP JSON endpoint, you can add transcoding and use the http_body stuff (see GIS servicer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API will support a button on the frontend to download a calendar file for the event.
Includes some refactoring of the ics generation code and tests, the biggest visible result being that we now create a sequence number based on a timestamp to support an arbitrary number of updates.
Fixes #9328
Testing
Added & updated tests.
Backend checklist
developif necessary for linear migration historyFor maintainers