Update NGSIEM start_search keyword guidance for FalconPy 1.6.5 - #85
Merged
Conversation
mraible
marked this pull request as draft
August 12, 2026 02:42
Foundry Skills Eval Results1/1 evals passed (100%) · model
On-demand eval run. Re-runs update this comment in place. |
prvn
previously approved these changes
Aug 12, 2026
The two-line version note pushed functions-falcon-api to 5513 tokens, over the 5500 budget. The original one-liner defers to the keyword section below, which already carries the explanation.
mraible
force-pushed
the
docs/ngsiem-search-keyword-1.6.5
branch
from
August 17, 2026 20:33
0519133 to
70e0ce9
Compare
Contributor
Author
|
Verified the claim against the v1.6.5 dev build on TestPyPI (discussion #1505), offline, since the guard is client side. The relevant line in
No change needed to this PR. Stable release is planned for 2026-08-20, so it can come out of draft then. |
mraible
marked this pull request as ready for review
August 17, 2026 23:09
mraible
enabled auto-merge (squash)
August 17, 2026 23:09
prvn
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FalconPy 1.6.5 fixed the bug where
body=was silently ignored byNGSIEM.start_search()(#1497, closes #1491). The skill previously statedbody=is broken; it now notes thatbody=works on 1.6.5+ but recommendssearch=as the version-agnostic default since FalconPy is unpinned.No example code changed.
search=remains in all examples.