Skip to content

Update NGSIEM start_search keyword guidance for FalconPy 1.6.5 - #85

Merged
mraible merged 2 commits into
mainfrom
docs/ngsiem-search-keyword-1.6.5
Aug 18, 2026
Merged

Update NGSIEM start_search keyword guidance for FalconPy 1.6.5#85
mraible merged 2 commits into
mainfrom
docs/ngsiem-search-keyword-1.6.5

Conversation

@mraible

@mraible mraible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

FalconPy 1.6.5 fixed the bug where body= was silently ignored by NGSIEM.start_search() (#1497, closes #1491). The skill previously stated body= is broken; it now notes that body= works on 1.6.5+ but recommends search= as the version-agnostic default since FalconPy is unpinned.

No example code changed. search= remains in all examples.

@mraible
mraible requested a review from a team August 12, 2026 02:38
@mraible
mraible marked this pull request as draft August 12, 2026 02:42
@app-foundry-fusion-prodsec-142274

app-foundry-fusion-prodsec-142274 Bot commented Aug 12, 2026

Copy link
Copy Markdown

Foundry Skills Eval Results

1/1 evals passed (100%) · model claude-opus-4-6 · commit 0519133

Eval Result Prompt
logscale-query-function
detailsI need a Foundry app that queries workflow execution data from LogScale. It should have a Python function that runs a LogScale query against the "fusion" repository to get workflow execution statistics (success/failure counts, average duration) for the last 24 hours, and a UI page that displays the results.

On-demand eval run. Re-runs update this comment in place.

prvn
prvn previously approved these changes Aug 12, 2026
The two-line version note pushed functions-falcon-api to 5513 tokens,
over the 5500 budget. The original one-liner defers to the keyword
section below, which already carries the explanation.
@mraible
mraible force-pushed the docs/ngsiem-search-keyword-1.6.5 branch from 0519133 to 70e0ce9 Compare August 17, 2026 20:33
@mraible

mraible commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Verified the claim against the v1.6.5 dev build on TestPyPI (discussion #1505), offline, since the guard is client side.

The relevant line in NGSIEM.start_search:

  • 1.6.4: search = kwargs.get("search", None) and then body=search, so a caller passing body= has it silently replaced by None
  • 1.6.5: search = kwargs.get("search", None) or body, so body= is honored as a fallback

search= is checked first in both, which is why it stays the version-agnostic recommendation while FalconPy is unpinned. Worth noting the 1.6.4 docstring already said search "can be used instead of body", so the documentation promised the behavior the guard did not implement.

No change needed to this PR. Stable release is planned for 2026-08-20, so it can come out of draft then.

@mraible
mraible marked this pull request as ready for review August 17, 2026 23:09
@mraible
mraible enabled auto-merge (squash) August 17, 2026 23:09
@mraible
mraible requested a review from a team August 18, 2026 03:39
@mraible
mraible merged commit 4a8921d into main Aug 18, 2026
6 checks passed
@mraible
mraible deleted the docs/ngsiem-search-keyword-1.6.5 branch August 18, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants