Skip to content

Name the deployment skill consistently with its siblings - #20

Merged
mraible merged 3 commits into
mainfrom
fix/deploy-skill-name-consistency
Aug 7, 2026
Merged

Name the deployment skill consistently with its siblings#20
mraible merged 3 commits into
mainfrom
fix/deploy-skill-name-consistency

Conversation

@mraible

@mraible mraible commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This is not a bug fix. The current setup works: the skill lives in skills/deployment/ and declares name: deploy, and it resolves and loads correctly either way. This is a naming consistency cleanup, safe to defer or decline.

deploy was the only imperative verb among six otherwise nominal skill names:

Skill Form
authoring gerund
deploy imperative verb
execution noun
lookup-files noun
setup noun
workflows noun

authoring / deployment / execution reads as a consistent trio; author / deploy / execute would too. Mixing one member of the second set into the first is the inconsistency. Nominal naming is also what foundry-skills uses across all ten of its skills.

There is a small side benefit: the command picker offered /crowdstrike-falcon-fusion:deploy (from the frontmatter) but rewrote it to :deployment (from the directory) on submit. With both set to deployment, there is nothing to rewrite.

Approach

Changed the frontmatter to name: deployment rather than renaming the directory to deploy. The frontmatter route is 15 lines across 6 files; the directory rename would have touched 21 path references across 8 files including CI config, for the same result.

Also updates the 12 places that named the skill deploy: the README skill table and lifecycle prose, the orchestrator's intent-routing table and handoff instructions, and cross-references in execution, lookup-files, and console-verification.md. (authoring already said "deployment.")

Prose using "deploy" as an ordinary verb is left alone.

Verification

  • ./test-validate.sh — 56 passed, 0 failed
  • ./test-hooks.sh — 14 passed, 0 failed

Stacking

Targets fix/bin-to-scripts (#18) rather than main, since #18 modifies four of the same SKILL.md files. GitHub will retarget this to main automatically once #18 merges.

@mraible
mraible requested review from a team and a lite review from Copilot August 5, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the Fusion plugin’s deployment sub-skill naming by switching the skill frontmatter name (and all documentation cross-references) from deploy to deployment, aligning it with the existing nominal naming pattern used by the other skills and reducing command-name rewriting ambiguity.

Changes:

  • Renames the deployment skill’s frontmatter name from deploydeployment.
  • Updates orchestrator routing guidance and cross-skill references to point to deployment.
  • Updates README documentation to reflect the new skill name in lifecycle descriptions and the skills table.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
skills/workflows/SKILL.md Updates routing decision tree and lifecycle instructions to invoke deployment instead of deploy.
skills/lookup-files/SKILL.md Updates “DO NOT TRIGGER” cross-skill guidance to reference deployment.
skills/execution/SKILL.md Updates references instructing users to use deployment for import/release steps.
skills/deployment/SKILL.md Changes the skill frontmatter name to deployment.
skills/deployment/references/console-verification.md Updates reference text pointing to the deployment skill.
README.md Updates skill routing/lifecycle documentation and the skills table to use deployment.

prvn
prvn previously approved these changes Aug 5, 2026
stack merge was automatically disabled August 7, 2026 03:02

Pull Request is not mergeable

stack merge was automatically disabled August 7, 2026 03:03

Pull Request is not mergeable

stack merge was automatically disabled August 7, 2026 05:33

Pull Request is not mergeable

@mraible
mraible force-pushed the fix/deploy-skill-name-consistency branch from 0cc7349 to 370ddb3 Compare August 7, 2026 05:33
Base automatically changed from fix/bin-to-scripts to main August 7, 2026 05:34
The skill declared 'name: deploy' while living in skills/deployment/.
Both resolve, so nothing was broken, but 'deploy' was the only
imperative verb among six otherwise nominal skill names (authoring,
execution, lookup-files, setup, workflows). Renaming the frontmatter to
'deployment' matches the directory and the authoring/execution pattern,
and it also removes a cosmetic quirk where the command picker offered
:deploy and rewrote it to :deployment on submit.

Changing the frontmatter rather than the directory keeps the diff to 15
lines with no path or CI churn, and follows the nominal naming used
throughout foundry-skills as well.

Updates the 12 references that named the skill 'deploy' across the
README, the orchestrator's routing table, and the sibling skills.
@mraible
mraible force-pushed the fix/deploy-skill-name-consistency branch from 370ddb3 to 1bbe957 Compare August 7, 2026 05:34
@mraible
mraible requested a review from prvn August 7, 2026 05:36
@mraible
mraible merged commit cd521ec into main Aug 7, 2026
6 checks passed
@mraible
mraible deleted the fix/deploy-skill-name-consistency branch August 24, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants