Correct three authoring-doc claims flagged in tech review (#30) - #32
Merged
Conversation
A Fusion engineer's review of an advanced-patterns walkthrough surfaced three factual errors that originated in the authoring skill docs. Correcting them at the source so future users and posts don't repeat them.
version_constraint is not class-specific. The Common Pitfalls row and the discovery checklist framed it as a requirement of class-based actions; in reality nearly every action carries a version_constraint regardless of whether it declares a class, so it should be recorded and included on every action node. This is doc framing only — validate.py behavior is unchanged.
System-level variables are not an exception. The yaml-schema variable list showed Trigger and Workflow fields in the bare ${Trigger.X} form. These fields live in the data namespace like any other field; the list now uses the ${data['...']} form (including CID, execution ID, and definition name) and notes that the bare form is only for dedicated ID property fields, cross-referencing the interpolation-vs-dedicated-field note in trigger-types.md.
Action name is a relabelable display field. The schema comment said the action name must match the catalog name. It defaults to the catalog display name but can be renamed freely — next:/conditions resolve by the node key and action id, not by this label.
Applied to both copies of yaml-schema.md (authoring and workflows references).
Fusion Skills Eval Results8/8 evals passed (100%) · model
Suggested improvements (7)
On-demand eval run. Re-runs update this comment in place. |
prvn
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30.
A Fusion engineer's technical review flagged three factual errors that originated in the authoring skill documentation. This corrects them at the source, in both copies of
yaml-schema.md(theauthoringandworkflowsreference sets) plus the authoringSKILL.md.version_constraintis not class-specific. The Common Pitfalls row and the discovery checklist framed it as a requirement of class-based actions. In reality nearly every action carries aversion_constraintregardless of whether it declares aclass, so it belongs on every action node. This changes doc framing only —validate.pybehavior is unchanged.System-level variables are not an exception. The variable-reference list showed trigger and workflow fields in the bare
${Trigger.X}form. Those fields live in thedatanamespace like any other field, so the list now uses the${data['...']}form (includingTrigger.CID,Workflow.Execution.ID, andWorkflow.Definition.Name) and notes that the bare form is only for dedicated ID property fields, cross-referencing the existing interpolation-vs-dedicated-field guidance intrigger-types.md.The action
name:field is a relabelable display label. The schema comment said it must match the catalog name. It defaults to the catalog display name but can be renamed freely —next:/conditions resolve by the node key and actionid, not by this label. The separate workflow-level name-stability guidance is unaffected and remains correct.Verified offline:
test-validate.sh(56/0),pytest(541 passed), markdownlint clean, and the authoringSKILL.mdstays within the skill size budget.