Skip to content

Add support for NuGet license files#1011

Open
mus65 wants to merge 2 commits intoCycloneDX:masterfrom
mus65:licensefile
Open

Add support for NuGet license files#1011
mus65 wants to merge 2 commits intoCycloneDX:masterfrom
mus65:licensefile

Conversation

@mus65
Copy link
Copy Markdown

@mus65 mus65 commented Feb 7, 2026

fixes #1001 .

This adds support for license files that are defined in the NuGet package.

  • if GitHub license resolution is disabled, it will prefer the license file to the license url (which has been deprecated for years) .
  • if GitHub license resolution is enabled, it will only fall back to the license file if nothing was found with GitHub, so this shouldn't break anything.

Some NuGet Packages that this would help with are Lucene.Net, LibGit2Sharp and Oracle.ManagedDataAccess.Core .

@mus65 mus65 requested a review from a team as a code owner February 7, 2026 10:17
@mus65 mus65 force-pushed the licensefile branch 3 times, most recently from 03f1a87 to d60c6a8 Compare February 7, 2026 10:36
@Falco20019
Copy link
Copy Markdown
Contributor

Would love to see this in the next release.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 1, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mtsfoni
Copy link
Copy Markdown
Member

mtsfoni commented Mar 1, 2026

Needs some small fixes, and I'll discuss if this should be the default behavior with a member of the core group.

Signed-off-by: Marius Thesing <marius.thesing@gmail.com>
@mtsfoni
Copy link
Copy Markdown
Member

mtsfoni commented Mar 1, 2026

@mus65 are you still working on this. I would take over as soon as I got the feedback from the core group

@mus65
Copy link
Copy Markdown
Author

mus65 commented Mar 1, 2026

@mtsfoni I'm done, just did a rebase because of a merge conflict (I merged master at first, but it triggered secret detection for some reason).

Signed-off-by: Marius Thesing <marius.thesing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuget with license file behaves different with enabled github resolve

3 participants