Open
Conversation
Generated by construct
Adds a --configuration / -c CLI option (e.g. Debug, Release) that is passed as -p:Configuration=<value> to dotnet restore. This causes NuGet to evaluate MSBuild Condition attributes on PackageReference items during restore, so configuration-specific packages (e.g. debug-only Avalonia.Diagnostics) are no longer included in the SBOM when a Release configuration is requested. Fixes: #1028 Generated by construct
- Update all existing Restore() mock setups from 3 to 4 args to match the updated interface signature - DotnetUtilsServiceTests: verify Restore() includes -p:Configuration= in the dotnet command when configuration is set, and omits it when null - ProjectFileServiceTests: verify GetProjectDotnetDependencysAsync forwards the configuration argument through to Restore() Generated by construct
Three E2E tests verify that conditional PackageReference items (with MSBuild Configuration conditions) are correctly included or excluded depending on the --configuration value passed to the tool. Also adds Configuration property to ToolRunOptions and wires it into BuildArgs() in CycloneDxRunner. Generated by construct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.