feat: embed compile time known arrays#107
Open
unsafePtr wants to merge 1 commit intoCysharp:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling ToCharArray/UTF8.GetBytes we can embed arrays at the compile time into assembly.
Don't be mislead by getter.
ReadOnly<x> name =>is a known way to embed information at compile time.Here is an example of how it looks like
https://sharplab.io/#gist:be78d99350441c76fc10efad8b76ea07
Compile-time known boundaries = possibility to remove boundaries when accessing array or constant-fold when. At worst it will improve initialization times.