Open
Conversation
In the writeregister() function, the I2CAddress type must be used instead of the byte type. The byte type is not sufficient to initialize the servo module when using more than one multiplexer; the servos will not work. Actually, there is no reason to use the byte type in the writeRegister() function . This function is inside the begin() function , to which the I2CAddress type is passed. And the writeRegister() function in turn calls I2CManager.write() , where the I2CAddress type is again used . So the only place where the byte type is is in the writeRegister() function.
Contributor
|
Thank you for finding that Filip! We have a user in the #betatesters channel on our DCC-EX Discord server who may have run into this bug, so I've rolled the fix into the devel branch v5.5.61 for testing. Once @habazut is online he'll no doubt accept the PR into prod. Feel free to join us on the Discord server too... we are keen to find more software contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the writeregister() function, the I2CAddress type must be used instead of the byte type. The byte type is not sufficient to initialize the servo module when using more than one multiplexer; the servos will not work. Actually, there is no reason to use the byte type in the writeRegister() function . This function is inside the begin() function , to which the I2CAddress type is passed. And the writeRegister() function in turn calls I2CManager.write() , where the I2CAddress type is again used . So the only place where the byte type is is in the writeRegister() function.