Refactor docker-compose for Dokploy deployment - #55
Conversation
Updated docker-compose.yml for Dokploy compatibility by removing host port bindings, container names, and adjusting volume paths. Changed ports to expose and improved logging configuration.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cce875711
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - /bin/sh | ||
| - -c | ||
| - "envsubst '$$OE_NGINX_CERT $$OE_NGINX_KEY' < /etc/nginx/nginx.conf.template > /etc/nginx/nginx.conf && exec nginx -g 'daemon off;'" | ||
| - "cp /etc/nginx/nginx.conf.template /etc/nginx/nginx.conf && exec nginx -g 'daemon off;'" |
There was a problem hiding this comment.
This command now copies the existing nginx template verbatim even though the compose file exposes only port 80 and removed the certificate environment/volume wiring. The mounted configs/nginx/nginx.conf still redirects port 80 to HTTPS and references ssl_certificate /etc/nginx/certs/${OE_NGINX_CERT}, so a Dokploy route to the proxy either loops back to HTTPS instead of reaching the app or the proxy fails to start because the cert paths/placeholders are not available. Update the template/command to produce a real HTTP-only config, or keep the TLS rendering and cert mounts.
Useful? React with 👍 / 👎.
1 participant
Updated docker-compose.yml for Dokploy compatibility by removing host port bindings, container names, and adjusting volume paths. Changed ports to expose and improved logging configuration.