Skip to content

>> Use SI.* where possible#288

Open
tobiasreischl wants to merge 29 commits intoDLR-SR:mainfrom
tobiasreischl:TFS_MediumChange
Open

>> Use SI.* where possible#288
tobiasreischl wants to merge 29 commits intoDLR-SR:mainfrom
tobiasreischl:TFS_MediumChange

Conversation

@tobiasreischl
Copy link
Copy Markdown
Contributor

@tobiasreischl tobiasreischl commented Feb 18, 2026

Changed from Medium.* to SI.* - closes Issue #16
keep SI.PressureDifference
SI.Pressure -> SI.AbsolutePressure only for p, not for r
Modelica.Units.SI. changed to SI.

IMPORTANT: Media not changed (for now)

@tobias-reischl
>> Use SI.* where possible DLR-SR#16
5150062 
> Changed from Medium.* to SI.*
> keep SI.PressureDifference
> SI.Pressure -> SI.AbsolutePressure only for p, not for r
> Modelica.Units.SI. changed to SI.

> IMPORTANT: Media not changed (for now)
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Reservoir.mo Outdated

protected
SI.Pressure p_env "Environmental pressure";
SI.AbsolutePressure p_env "Environmental pressure";
Copy link
Copy Markdown
Collaborator

@RaphaelGebhart RaphaelGebhart Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep SI.AbsolutePressure. Do not change to Medium.AbsolutePressure.

RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Undirected/Boundaries/Reservoir.mo Outdated
parameter Boolean pEnvFromInput = false "=true, if environmental pressure input connector is enabled"
annotation(Dialog(group="Environmental pressure"),Evaluate=true, HideResult=true, choices(checkBox=true));
parameter SI.Pressure p_env_par=1e5 "Environmental pressure set value"
parameter SI.AbsolutePressure p_env_par=1e5 "Environmental pressure set value"
Copy link
Copy Markdown
Collaborator

@RaphaelGebhart RaphaelGebhart Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change to Medium.AbsolutePressure.

RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Undirected/Boundaries/Reservoir.mo Outdated

protected
SI.Pressure p_env "Environmental pressure";
SI.AbsolutePressure p_env "Environmental pressure";
Copy link
Copy Markdown
Collaborator

@RaphaelGebhart RaphaelGebhart Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change to Medium.AbsolutePressure.

@RaphaelGebhart
Copy link
Copy Markdown
Collaborator

RaphaelGebhart commented Feb 24, 2026 •
edited by tobiasreischl
Loading

The requested changes always refer to the last line of the preview.

  • Modelica.Units.SI.* -> SI.*
  • Pressure -> AbsolutePressure for p_in, p_out, etc. Not for dp, r
  • Apply requested changes.
  • SI.* -> Medium.* whenever possible (AbsolutePressure, Temperature, etc., see Modelica.Media.Interfaces.Types (ThermofluidStream.Media.myMedia.Interfaces.Types). Currently, the change was applied in the opposite direction, i.e. Medium.* was replaced by SI.*.

RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Boundaries/Internal/PartialTank.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/FlowControl/Internal/PartialValve.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Processes/Internal/FlowResistance/partialPressureLoss.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Processes/Internal/PartialConductionElement.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Processes/Internal/PartialConductionElement.mo Outdated
RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Processes/Pipes/BaseClasses/WallFriction/Utilities/DarcyFriction.mo
input SI.Density rho "Inlet density";
input SI.DynamicViscosity mu "Dynamic viscosity";
input Real Re1 "Lower boundary Re for laminar-turbulent transition regime";
input Real Re2 "Upper boundary Re for laminar-turbulent transition regime";
Copy link
Copy Markdown
Collaborator

@RaphaelGebhart RaphaelGebhart Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
input Real Re2 "Upper boundary Re for laminar-turbulent transition regime";
input SI.ReynoldsNumber Re2 "Upper boundary Re for laminar-turbulent transition regime";

RaphaelGebhart
RaphaelGebhart reviewed Feb 24, 2026
View reviewed changes
Comment thread ThermofluidStream/Processes/Pipes/Interfaces/partialJunctionY.mo
SI.AbsolutePressure p_branching "Total pressure branching inlet";
SI.AbsolutePressure p[2] = {p_straight, p_branching} "Total pressure inlets [straight branching]";

SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet";
Copy link
Copy Markdown
Collaborator

@RaphaelGebhart RaphaelGebhart Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet";
SI.PressureDifference dq_straight "Dynamic pressure difference straight inlet - outlet";

tobiasreischl and others added 25 commits March 9, 2026 10:30
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Boundaries/Internal/PartialTank.mo
9bc06d0 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
1a91f77 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Boundaries/Internal/PartialTank.mo
4f06f25 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Boundaries/Internal/PartialTank.mo
d052af3 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Boundaries/Internal/PartialTank.mo
9ce2827 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Boundaries/Internal/PartialTank.mo
dbe2acc 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/FlowControl/Internal/PartialValve.mo
0405456 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Internal/FlowResistance/laminarTur…
b46c138 
…bulentPressureLossHaaland.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Internal/FlowResistance/laminarTur…
d2f8ce5 
…bulentPressureLossHaaland.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Internal/FlowResistance/partialPre…
ab03bd5 
…ssureLoss.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Internal/PartialConductionElement.mo
6acfad3 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Internal/PartialConductionElement.mo
22b3a31 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Pipes/BaseClasses/WallFriction/Uti…
c7099bf 
…lities/DarcyFriction.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/Pipes/Internal/Interfaces/partialJ…
6281a22 
…unctionY.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Processes/ThermalConvectionPipe.mo
81f5b04 
Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
43644c5 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
44e0df2 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
ed59eb2 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
421dfeb 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
60d5e41 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
97a0f2e 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
6ec5174 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
81f9548 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
a921430 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@tobiasreischl @RaphaelGebhart
Update ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUn…
952acc2 
…directed.mo

Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
@CorentinLepais CorentinLepais linked an issue Mar 10, 2026 that may be closed by this pull request
Use Medium.* instead of SI.* where possible #16
Open
@tobias-reischl
> Changed SI.* to Medium.* wherever possible
16c6e02 
> Checked with "Check" button and works fine now
@tobiasreischl
Copy link
Copy Markdown
Contributor Author

tobiasreischl commented Mar 10, 2026

Done - final review (needed?) @RaphaelGebhart - or just merge

@RaphaelGebhart RaphaelGebhart self-requested a review March 24, 2026 09:29
@RaphaelGebhart
Copy link
Copy Markdown
Collaborator

RaphaelGebhart commented Apr 7, 2026

Regression test passed (according to @tobiasreischl).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaphaelGebhart RaphaelGebhart Awaiting requested review from RaphaelGebhart

Requested changes must be addressed to merge this pull request.

Assignees

@tobiasreischl tobiasreischl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Medium.* instead of SI.* where possible

4 participants

@tobiasreischl @RaphaelGebhart @CorentinLepais @tobias-reischl