Fixed PartialSimpleIdealGasMedium.setState_psX#294
Open
RaphaelGebhart wants to merge 1 commit intoDLR-SR:mainfrom
Open
Fixed PartialSimpleIdealGasMedium.setState_psX#294RaphaelGebhart wants to merge 1 commit intoDLR-SR:mainfrom
RaphaelGebhart wants to merge 1 commit intoDLR-SR:mainfrom
Conversation
CorentinLepais
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
There was indeed a small error in the formula, even if the results do not change. From a physics point of view, I would have written it like below to keep the exponential without unit and to make more obvious that it calculates a temperature :
reference_T*exp(s/cp_const +R_gas/cp_const*Modelica.Math.log(p/reference_p))
Since this error is also in the MSL, should an issue be created in the MSL repository?
Collaborator
Author
|
Yes i already created one: modelica/ModelicaStandardLibrary#4750 And yes Im also in favor of the version you suggested. Lets chose this one. I will run a regression test with the new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test passed.