add support for user attributes on user accounts#2588
Open
richard-jones wants to merge 3 commits into
Open
Conversation
usman-cottagelabs
left a comment
There was a problem hiding this comment.
1 bug found. See the Issue itself for the bug.
|
@richard-jones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add attributes to user accounts
In preparation for Editorial Workflow, this adds the ability for users to have attributes which describe their capabilities
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constantsormessagesfilesdates)url_fornot hard-codeddevelopReviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constantsormessagesfilesdates)url_fornot hard-codeddevelopTesting
For testing the migration, the csv files located in this CL google drive folder can be used https://drive.google.com/drive/u/0/folders/1kbDPodh1ZrhrzuccXfHVWbyg8c0iX8Sh
For testing the feature and regression, all the tests from the User Management testbook can be used
https://doaj.github.io/doaj-docs/feature/4317_user_attributes/testbook/index.html#user_management/user_management
Deployment
Configuration changes
N/A
Scripts
N/A
Migrations
You will need to have the country csv and language csv provided at migration time, these come from a private editorial spreadsheet.
You may also supply
--dry-runon initial migration to determine that it will take correctly.Monitoring
N/A
New Infrastructure
N/A
Continuous Integration
N/A