WIP: Allow GDAL PDS format to be read#6023
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6023". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6023". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| #include "SpecialPixel.h" | ||
| #include "UserInterface.h" | ||
|
|
||
| #include "cpl_vsi.h" |
There was a problem hiding this comment.
Is there documentation for this API? I'm not sure if this is something we want to commit ourselves to
There was a problem hiding this comment.
Seems like enough of a documented API exists for this at:
https://gdal.org/en/stable/api/cpl.html#cpl-vsi-h
There was a problem hiding this comment.
I agree that we do not want to use the VSI API directly, let GDAL handle it via /vsi prefixes.
There was a problem hiding this comment.
This may be the best way to handle this to be as minimally invasive as possible. The other option would be to add a new organiztion option to the importer specifically for vis. We would then have to add a custom member function to support ISIS functors
There was a problem hiding this comment.
Thinking about this a bit more, I don't think the GDAL raster IO supports random byte access. Something to double check
Description
Enables native support for virtual file systems and remote streaming (/vsicurl/) by using GDAL's VSI API. Local file usage performance should not be affected since VSI is basically a pass-through to standard C
fopencalls.Related Issue
Addresses #5864
How Has This Been Validated?
Tested
/vsicurlURL:Also ran
mroctx2isiswith the downloaded version to completion.Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: