isisimport case-insensitive data file check#6024
isisimport case-insensitive data file check#6024jrcain-usgs wants to merge 6 commits intoDOI-USGS:devfrom
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
left a comment
There was a problem hiding this comment.
Overall looks good! A couple of things to address
acpaquette
left a comment
There was a problem hiding this comment.
A couple more things to address
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
left a comment
There was a problem hiding this comment.
Another couple of minor tweaks
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_6024". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
acpaquette
left a comment
There was a problem hiding this comment.
Code looks good, just waiting for tests to come back
|
Tests are failing: |
isisimportcan now succeed on linux for a label where the related data file's file extension is not in the expected case.Description
A user had trouble running isisimport on a pair of files, .xml and .IMG. On linux, isisimport looked for a lowercase .img file only, and failed. It will be easier for users if isisimport works files with both upper and lowercase extensions.
Related Issue
Fixes #5971
How Has This Been Validated?
Tested with a Chandrayaan 2 image (ch2_tmc_nca_20200118T1731219963_d_img_d18.xml, and the matching .IMG file) on a linux machine.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: