Skip to content

isisimport case-insensitive data file check#6024

Open
jrcain-usgs wants to merge 6 commits intoDOI-USGS:devfrom
jrcain-usgs:isisimport-case-sensitive
Open

isisimport case-insensitive data file check#6024
jrcain-usgs wants to merge 6 commits intoDOI-USGS:devfrom
jrcain-usgs:isisimport-case-sensitive

Conversation

@jrcain-usgs
Copy link
Copy Markdown
Contributor

isisimport can now succeed on linux for a label where the related data file's file extension is not in the expected case.

Description

A user had trouble running isisimport on a pair of files, .xml and .IMG. On linux, isisimport looked for a lowercase .img file only, and failed. It will be easier for users if isisimport works files with both upper and lowercase extensions.

Related Issue

Fixes #5971

How Has This Been Validated?

Tested with a Chandrayaan 2 image (ch2_tmc_nca_20200118T1731219963_d_img_d18.xml, and the matching .IMG file) on a linux machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jrcain-usgs jrcain-usgs changed the title isisimport case-insensitive data file checking isisimport case-insensitive data file check Apr 23, 2026
@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@jrcain-usgs jrcain-usgs requested a review from acpaquette April 23, 2026 20:56
Copy link
Copy Markdown
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! A couple of things to address

Comment thread isis/src/base/apps/isisimport/isisimport.cpp Outdated
Comment thread isis/src/base/apps/isisimport/isisimport.cpp
@jrcain-usgs jrcain-usgs requested a review from acpaquette April 24, 2026 03:09
Copy link
Copy Markdown
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things to address

Comment thread isis/src/base/apps/isisimport/isisimport.cpp Outdated
Comment thread isis/src/core/include/FileName.h Outdated
@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@jrcain-usgs jrcain-usgs requested a review from acpaquette April 24, 2026 18:47
Copy link
Copy Markdown
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another couple of minor tweaks

Comment thread isis/src/base/apps/isisimport/isisimport.cpp Outdated
Comment thread isis/src/base/apps/isisimport/isisimport.h Outdated
@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Comment thread isis/src/base/apps/isisimport/isisimport.cpp Outdated
@jrcain-usgs jrcain-usgs requested a review from acpaquette April 24, 2026 20:02
@github-actions
Copy link
Copy Markdown

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_6024".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Copy link
Copy Markdown
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just waiting for tests to come back

@acpaquette
Copy link
Copy Markdown
Collaborator

Tests are failing:

	1664 - TempTestingFiles.FunctionalTestIsisImportLabelXmlInput (Failed)
	1669 - TempTestingFiles.FunctionalTestIsisImportCassiniIssNac (Failed)
	1670 - TempTestingFiles.FunctionalTestIsisImportCassiniIssWac (Failed)
	1671 - TempTestingFiles.FunctionalTestIsisImportCassiniIssCustomMax (Failed)
	1672 - TempTestingFiles.FunctionalTestIsisImportChandrayaan2TmcMinimalLabel (Failed)
	1673 - TempTestingFiles.FunctionalTestIsisImportChandrayaan2TmcFullLabel (Failed)
	1674 - TempTestingFiles.FunctionalTestIsisImportChandrayaan2OhrcFullLabel (Failed)
	1675 - TempTestingFiles.FunctionalTestIsisImportEisNacFrame (Failed)
	1676 - TempTestingFiles.FunctionalTestIsisImportEisWacFrame (Failed)
	1677 - TempTestingFiles.FunctionalTestIsisImportEisWacPb (Failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isisimport error .img vs .IMG - should be case insensitive on linux and mac

2 participants