Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
data-provider-name="<%= employer.provider_name %>"
class="usa-button usa-button--outline"
type="button"
aria-label="<%= employer.name %>"
aria-label="<%= t(".select_employer", name: employer.name) %>"
>
<%= t(".select") %>
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
data-cbv-employer-search-target="employerButton"
type="button"
class="width-full height-full usa-button usa-button--outline box-shadow-gray"
aria-label="<%= t(".select_employer", name: provider.name) %>"
>
<figure class="margin-0 pointer-events-none">
<img
Expand Down
2 changes: 1 addition & 1 deletion app/app/views/cbv/employer_searches/_employer.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
class="usa-button usa-button--outline"
type="button"
tabindex="0"
aria-label="<%= employer.name %>"
aria-label="<%= t(".select_employer", name: employer.name) %>"
>
<%= t("cbv.employer_searches.show.select") %>
</button>
Expand Down
1 change: 1 addition & 0 deletions app/app/views/cbv/employer_searches/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
data-cbv-employer-search-target="employerButton"
type="button"
class="width-full height-full usa-button usa-button--outline box-shadow-gray"
aria-label="<%= t(".select_employer", name: provider.name) %>"
>
<figure class="margin-0 pointer-events-none">
<img
Expand Down
5 changes: 5 additions & 0 deletions app/config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ en:
other: We found %{count} results
search_subheader: Select your employer from the list. Then, follow the screens to sign in. Use the login credentials you use to view your pay stubs online.
select: Select
select_employer: Select %{name}
show:
add_employment_manually: Add employment manually
alert:
Expand All @@ -391,6 +392,7 @@ en:
search: Search
search_label: Search for the employer or business you want to add. If you can't find it, you can add it manually.
search_results_header: Select your employer
select_employer: Select %{name}
error_no_access: You don't have permission to access that information
payment_details:
show:
Expand Down Expand Up @@ -753,6 +755,8 @@ en:
other: "%{count} errors"
error_updating_applicant: An error occurred while updating the applicant information. Please try again.
employer_searches:
employer:
select_employer: Select %{name}
show:
alert:
heading: Need help connecting to your payroll provider?
Expand Down Expand Up @@ -782,6 +786,7 @@ en:
search_label: This can be your current employer. This can also be any recent employer from the past 90 days if you’re no longer working.
search_subheader: Select your employer from the list. Then, follow the screens to log in and verify your income.
select: Select
select_employer: Select %{name}
to_continue: 'If you still don’t see your employer or payroll provider listed:'
to_continue_li_1: You’ll need to submit that income information separately.
to_continue_li_1_html: <a href="%{agency_contact_website}" target="_blank" rel="noopener noreferrer">Go to %{agency_acronym}'s website</a> to learn about other ways to report your income.
Expand Down
3 changes: 3 additions & 0 deletions app/config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ es:
other: "%{count} errores"
error_updating_applicant: Se produjo un error al actualizar la información del solicitante. Vuelva a intentarlo.
employer_searches:
employer:
select_employer: Seleccione %{name}
Comment thread
ccvetter marked this conversation as resolved.
Outdated
show:
alert:
heading: "¿Necesita ayuda para conectarse a su proveedor de nómina?"
Expand Down Expand Up @@ -208,6 +210,7 @@ es:
search_label: Este puede ser su empleador actual. Si no está trabajando, puede buscar cualquier empleador que haya tenido en los últimos 90 días.
search_subheader: 'Seleccione su empleador de la lista. Luego, siga las instrucciones en las pantallas para iniciar la sesión y verificar su ingreso. '
select: Seleccione
select_employer: Seleccione %{name}
Comment thread
ccvetter marked this conversation as resolved.
Outdated
to_continue: 'Si aún no ve enumerado a su empleador ni a su proveedor de nómina:'
to_continue_li_1: Deberá enviar esa información de ingresos por separado.
to_continue_li_1_html: <a href="%{agency_contact_website}" target="_blank" rel="noopener noreferrer">Visite el sitio web del %{agency_acronym}</a> para informarse de otras formas de notificar sus ingresos.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@
expect(response.body).not_to include(I18n.t("activities.income.employer_searches.show.popular_providers"))
expect(response.body).not_to include(I18n.t("cbv.employer_searches.show.employer_not_listed"))
end

it "has aria-labels for each employer button" do
get :show, params: { query: "results" }
Comment thread
ccvetter marked this conversation as resolved.
expect(response.body).to include('aria-label="Select Walgreens"')
expect(response.body).to include('aria-label="Select Greens Group"')
end
end

context "when there are no search results" do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@
expect(response).to be_successful
end

it "has aria-labels for each employer button" do
Comment thread
ccvetter marked this conversation as resolved.
Outdated
get :show, params: { query: "results" }
expect(response.body).to include('aria-label="Select Walgreens"')
expect(response.body).to include('aria-label="Select Greens Group"')
end

it "tracks a Mixpanel event" do
allow(EventTrackingJob).to receive(:perform_later).with("CbvPageView", anything, anything)
expect(EventTrackingJob).to receive(:perform_later).with(
Expand Down
Loading