Enforce server command invariants more in the client#1955
Open
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Open
Enforce server command invariants more in the client#1955slipher wants to merge 2 commits intoDaemonEngine:masterfrom
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Conversation
Have the client drop the connection in these cases: - A gamestate that decreases the sequence number. This should be impossible because the netchan guarantees that packets can't be reordered, although they may be dropped. - A server command which a sequence number higher than the next one. This should be impossible because the server re-sends all unacknowledged commands together each time. If the number jumped by more than one the client would end up re-executing old garbage from the buffer.
A special case to allow demos to request bad command ranges is not needed. The gamestate generated when starting the demo sets the serverCommandSequence number appropriately, so the demo replay will be able to request the correct range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server reliable commands are expected to arrive in order and are re-sent if packets are dropped. Do a bit more checking on the client side that the protocol is observed.
I tested this along with #1954 by playing in some online games and replaying demos.