Physical Flaws (Part Two)#1176
Open
Icarus-The-Sun wants to merge 5 commits into
Open
Conversation
Contributor
|
You currently have a negative Fix/Feature pull request delta of -6. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
FalloutFalcon
approved these changes
Jun 24, 2026
| if(HAS_TRAIT(user, TRAIT_GRAVE_SMELL)) | ||
| involved_social_roll += 1 | ||
| if((HAS_TRAIT(user, TRAIT_GLOWING_EYES)) && (!user.is_eyes_covered()) && (used_stat == STAT_INTIMIDATION)) | ||
| involved_social_roll -= 1 |
Member
There was a problem hiding this comment.
It might make sense to genersise this into a "get mortal indtimidation" getter or something as you copypaste similar code into a few other procs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds the Disfigured (481), Glowing Eyes (482), and Smell of the Grave (481) flaws. Touches discipline code to make them apply penalties (and add a boost for intimidation for glowing eyes).
Glowing eyes applies a -1 perception penalty, and gives a boost (-1 diff) to intimidation rolls against non-kindred. Also, masq violating eyes. Users spawn with sunglasses if they take it. (Kindred only)
Disfigured adds a penalty (+2 diff) to social rolls in general, and caps appearance to 2. (Not splat restricted)
Smell of the Grave adds a penalty (+1 diff) to social rolls against mortals. (Kindred only)
Details
Disfigured: App 5 being disfigured.
Glowing Eyes:
Glowing eyes in the dark.
Out of the dark.
Flavor text when eyes are exposed.
Smell of the Grave:
Flavor text.
Why It's Good For The Game
More flaws.
Changelog
🆑
add: Adds Disfigured, Glowing Eyes, and Smell of the Grave flaws
/:cl: