Telepathy cooldown separation + rebalance + char limit increased#1177
Open
Ambrose997 wants to merge 1 commit into
Open
Telepathy cooldown separation + rebalance + char limit increased#1177Ambrose997 wants to merge 1 commit into
Ambrose997 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
EDIT: PLEASE MERGE #1181 BEFORE THIS ONE. TY.
Separates the cooldowns for telepathy, only disguise_voice has a roll for implant thoughts, cancellable without triggering cooldown or willpower reduction, rebalances mind reading's cooldown to 3 minutes and implant thoughts to 5 seconds.
This was initially intended for TFN but as I was messing around with this I realized that it should probably just be upstreamed due to how much it has been changed and because I do genuinely think the functionality and balancing is better than it was previously (totally not because I don't want to fuck around with TFN edits). As a result the maximum length of the specific_search input is multiplied by 10 (1024 -> 10240) based on a quality of life PR made on TFN.
I do not think this is particularly a problem for the upstream given how much has been changed in this PR already
Why It's Good For The Game
Highly requested on TFN since the telepathy cooldown was increased to 9 minutes whilst also only having 1 cooldown for both ability options, completely preventing any form of mental communication realistically that people enjoyed using it for) and probably why the cooldown is set to 1 turn on this repo despite the mind reading ability being pretty powerful and spammable even if it uses WP against splats.
You can easily set separate cooldowns for future balancing if you disagree with the cooldowns I've set here.
Addresses the concerns of the power that mind reading has whilst allowing for regular telepathic communication and allows you to nerf/buff either one without impacting the other.
Clicking "cancel" now actually cancels usage of the ability rather than going forward and wasting a cooldown timer as well as stopping you from wasting willpower if it was a supernatural you clicked before changing your mind.
Rolls upon picking mind reading or disguise thoughts prevents people from selecting implant thoughts on bad rolls to avoid triggering the cooldown of mind reading and only selecting mind reading if their rolls are good.
Lack of a roll for implant thoughts allows for more regular communication and it makes sense to only roll when you disguise its origin rather than having to get through two rolls of varying difficulty, whereas before you had to both pass the telepathy_success and disguise_voice_roll rolls.
Cooldowns are actually sane now.
Disclaimer to players: Don't use implant thoughts to be antisocial dickheads or that generously low cooldown will probably be increased by your respective forks. Use it wisely.
Changelog
🆑
code: Mind reading success rolls after it's picked from the telepathy menu rather than before.
code: Undisguised Implant Thought usage no longer requires a roll.
code: Separates the mind reading and implant thought cooldowns.
balance: Mind Reading cooldown set to 3 Minutes.
balance: Implant Thought cooldown set to 5 seconds.
balance: Increases message length for the specific thought searches via mind reading (From TFN).
fix: Clicking "Cancel" on the telepathy menu no longer runs the highlighted option anyway.
fix: fixed previously unnoticed bug resulting from nested quotes clashing.
/:cl: