Revert "Adding temporary command to create the Agent schema"#48956
Closed
datadog-prod-us1-3[bot] wants to merge 1 commit intomainfrom
Closed
Revert "Adding temporary command to create the Agent schema"#48956datadog-prod-us1-3[bot] wants to merge 1 commit intomainfrom
datadog-prod-us1-3[bot] wants to merge 1 commit intomainfrom
Conversation
This reverts commit 118f309.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70e018087c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # # @param dns_monitoring_ports - list of integers - optional - default: [53] | ||
| # # @env DD_NETWORK_CONFIG_DNS_MONITORING_PORTS - space separated list of integers - optional - default: '53' | ||
| # # @env DD_SYSTEM_PROBE_CONFIG_DNS_MONITORING_PORTS - space separated list of integers - optional - default: [53] |
There was a problem hiding this comment.
The template now documents DD_SYSTEM_PROBE_CONFIG_DNS_MONITORING_PORTS, but system_probe.go binds network_config.dns_monitoring_ports without an explicit env override (cfg.BindEnvAndSetDefault("network_config.dns_monitoring_ports", ...)), so the effective variable is DD_NETWORK_CONFIG_DNS_MONITORING_PORTS after prefix/key replacement. Users following this template will set an env var that is never read, leaving DNS monitoring ports at defaults and causing unexpected DNS collection behavior.
Useful? React with 👍 / 👎.
Contributor
Gitlab CI Configuration ChangesRemoved Jobs
Changes Summary
ℹ️ Diff available in the job log. |
Contributor
Go Package Import DifferencesBaseline: 00ba578
|
Contributor
Files inventory check summaryFile checks results against ancestor 00ba5786: Results for datadog-agent_7.79.0~devel.git.469.70e0180.pipeline.106409984-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 118f309 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -4.50 | [-7.46, -1.54] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otlp_ingest_metrics | memory utilization | +0.58 | [+0.43, +0.74] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.36 | [+0.20, +0.52] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.28 | [+0.24, +0.31] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.24 | [+0.06, +0.43] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.07 | [+0.01, +0.12] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.39, +0.48] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.11, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.51, +0.51] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.42, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.14, +0.07] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.05 | [-0.27, +0.17] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.10 | [-0.24, +0.04] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.15 | [-0.21, -0.09] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.18 | [-0.25, -0.12] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.43 | [-0.49, -0.38] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.59 | [-2.25, +1.06] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | -0.65 | [-0.84, -0.47] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.83 | [-0.94, -0.71] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.14 | [-1.38, -0.90] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -1.83 | [-1.98, -1.68] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -4.50 | [-7.46, -1.54] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 677 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 273.90MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 672 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 172.48MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 487.50MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 201.60MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 348.30 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 428.60MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
3 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
joepeeples
approved these changes
Apr 7, 2026
| # disabled: true | ||
| # | ||
| # # @param ping - custom object - optional | ||
| # # Configure ICMP pings for all hosts in SNMP autodiscovery |
Contributor
There was a problem hiding this comment.
Suggested change
| # # Configure ICMP pings for all hosts in SNMP autodiscovery | |
| # # Configure ICMP pings for all hosts in SNMP autodiscovery. |
| # # check is run. | ||
| # # | ||
| # # By default, Datadog tries to use an unprivileged UDP socket to send ICMP | ||
| # # pings, but some linux systems require using a raw socket. |
Contributor
There was a problem hiding this comment.
Suggested change
| # # pings, but some linux systems require using a raw socket. | |
| # # pings, but some Linux systems require using a raw socket. |
aiuto
approved these changes
Apr 7, 2026
Member
|
The CI failure were unlelated to this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic revert of commit 118f309.
This PR is created to anticipate the resolution of
invoke_unit_testsjob failure inmainbranch in case of erroneous code change.If this revert is incorrect, do not hesitate to close the PR.