Skip to content

Add missing public registries for K8s SSI gradual rollout#48982

Open
erikayasuda wants to merge 5 commits intomainfrom
erikayasuda/add-default-dd-registries
Open

Add missing public registries for K8s SSI gradual rollout#48982
erikayasuda wants to merge 5 commits intomainfrom
erikayasuda/add-default-dd-registries

Conversation

@erikayasuda
Copy link
Copy Markdown
Contributor

@erikayasuda erikayasuda commented Apr 7, 2026

What does this PR do?

Adding the remaining public registries from the public-images repo to admission_controller.auto_instrumentation.default_dd_registries. See source here.

Motivation

Missing these registries from the default values means that customers specifying these registries would not be included in gradual rollout, they would immediately use the latest available release.

Given the recent change in the helm chart to set registry.datadoghq.com as the default registry instead of gcr.io/datadoghq (DataDog/helm-charts#2523), this means that as customers upgrade their agent version and consequently their helm chart version, they will start to be excluded from gradual rollout even if they were once included.

Describe how you validated your changes

Updated existing DD registry check tests.

Additional Notes

@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-configuration labels Apr 7, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Apr 7, 2026
@erikayasuda erikayasuda changed the title Add missing public registries for gradual rollout Add missing public registries for K8s SSI gradual rollout Apr 7, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Apr 7, 2026

Files inventory check summary

File checks results against ancestor b255eccb:

Results for datadog-agent_7.79.0~devel.git.574.dcc8b95.pipeline.106928929-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Apr 7, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b255ecc
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +4.0 KiB (0.00% increase) 751.366 → 751.370 → 753.380
agent_heroku_amd64 +4.0 KiB (0.00% increase) 311.732 → 311.736 → 320.580
agent_msi +5.5 KiB (0.00% increase) 605.292 → 605.297 → 651.440
agent_rpm_amd64 +4.0 KiB (0.00% increase) 751.349 → 751.353 → 753.350
agent_rpm_arm64 +8.0 KiB (0.00% increase) 729.737 → 729.745 → 735.290
agent_rpm_arm64_fips +4.0 KiB (0.00% increase) 689.697 → 689.701 → 696.840
agent_suse_amd64 +4.0 KiB (0.00% increase) 751.349 → 751.353 → 753.350
agent_suse_arm64 +8.0 KiB (0.00% increase) 729.737 → 729.745 → 735.290
agent_suse_arm64_fips +4.0 KiB (0.00% increase) 689.697 → 689.701 → 696.840
docker_agent_amd64 +4.0 KiB (0.00% increase) 811.636 → 811.640 → 815.700
docker_agent_arm64 +8.0 KiB (0.00% increase) 814.829 → 814.837 → 821.970
docker_agent_jmx_amd64 +4.0 KiB (0.00% increase) 1002.551 → 1002.555 → 1006.580
docker_agent_jmx_arm64 +8.0 KiB (0.00% increase) 994.523 → 994.531 → 1001.570
docker_dogstatsd_amd64 +4.0 KiB (0.01% increase) 39.278 → 39.282 → 39.380
iot_agent_deb_armhf +4.0 KiB (0.01% increase) 41.247 → 41.251 → 42.100
16 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 708.266 MiB
agent_rpm_amd64_fips 708.249 MiB
agent_suse_amd64_fips 708.249 MiB
docker_cluster_agent_amd64 204.124 MiB
docker_cluster_agent_arm64 218.547 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_arm64 37.508 MiB
dogstatsd_deb_amd64 29.925 MiB
dogstatsd_deb_arm64 28.074 MiB
dogstatsd_rpm_amd64 29.925 MiB
dogstatsd_suse_amd64 29.925 MiB
iot_agent_deb_amd64 43.465 MiB
iot_agent_deb_arm64 40.500 MiB
iot_agent_rpm_amd64 43.465 MiB
iot_agent_suse_amd64 43.465 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +19.12 KiB (0.01% increase) 174.566 → 174.584 → 178.360
agent_deb_amd64_fips -30.35 KiB (0.02% reduction) 165.212 → 165.182 → 172.790
agent_heroku_amd64 +6.02 KiB (0.01% increase) 74.837 → 74.843 → 79.970
agent_msi +8.0 KiB (0.01% increase) 138.500 → 138.508 → 146.220
agent_rpm_amd64 +14.43 KiB (0.01% increase) 177.420 → 177.434 → 181.830
agent_rpm_amd64_fips +53.9 KiB (0.03% increase) 167.257 → 167.309 → 173.370
agent_rpm_arm64 -38.85 KiB (0.02% reduction) 159.368 → 159.330 → 163.060
agent_rpm_arm64_fips -26.87 KiB (0.02% reduction) 151.249 → 151.223 → 156.170
agent_suse_amd64 +14.43 KiB (0.01% increase) 177.420 → 177.434 → 181.830
agent_suse_amd64_fips +53.9 KiB (0.03% increase) 167.257 → 167.309 → 173.370
agent_suse_arm64 -38.85 KiB (0.02% reduction) 159.368 → 159.330 → 163.060
agent_suse_arm64_fips -26.87 KiB (0.02% reduction) 151.249 → 151.223 → 156.170
docker_agent_amd64 +9.45 KiB (0.00% increase) 267.973 → 267.982 → 272.480
docker_agent_arm64 +2.77 KiB (0.00% increase) 255.142 → 255.145 → 261.060
docker_agent_jmx_amd64 +5.84 KiB (0.00% increase) 336.628 → 336.633 → 341.100
docker_agent_jmx_arm64 neutral 319.790 MiB → 325.620
docker_cluster_agent_amd64 neutral 71.433 MiB → 72.920
docker_cluster_agent_arm64 neutral 67.053 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.998 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.184 MiB → 15.820
docker_dogstatsd_arm64 -3.9 KiB (0.03% reduction) 14.505 → 14.501 → 14.830
dogstatsd_deb_amd64 neutral 7.901 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.786 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.912 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.912 MiB → 8.800
iot_agent_deb_amd64 neutral 11.447 MiB → 13.040
iot_agent_deb_arm64 neutral 9.765 MiB → 11.450
iot_agent_deb_armhf neutral 9.979 MiB → 11.620
iot_agent_rpm_amd64 neutral 11.465 MiB → 13.060
iot_agent_suse_amd64 neutral 11.465 MiB → 13.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Apr 7, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d96555f2-9e60-4795-a1dd-0abdeb60b88d

Baseline: b255ecc
Comparison: dcc8b95
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • docker_containers_cpu

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.18 [-1.80, +4.16] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.18 [-1.80, +4.16] 1 Logs
ddot_metrics memory utilization +0.63 [+0.45, +0.82] 1 Logs
quality_gate_logs % cpu utilization +0.54 [-1.11, +2.18] 1 Logs bounds checks dashboard
file_tree memory utilization +0.53 [+0.48, +0.59] 1 Logs
otlp_ingest_logs memory utilization +0.44 [+0.34, +0.54] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.28 [+0.22, +0.34] 1 Logs
otlp_ingest_metrics memory utilization +0.27 [+0.12, +0.43] 1 Logs
quality_gate_idle_all_features memory utilization +0.26 [+0.23, +0.30] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.19 [-0.04, +0.43] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.16 [-0.01, +0.33] 1 Logs
ddot_logs memory utilization +0.13 [+0.07, +0.19] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.08, +0.15] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.40, +0.47] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.02 [-0.20, +0.25] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.21, +0.20] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.42, +0.39] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.56, +0.50] 1 Logs
quality_gate_idle memory utilization -0.12 [-0.17, -0.06] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.30 [-0.48, -0.11] 1 Logs
docker_containers_memory memory utilization -0.39 [-0.48, -0.30] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.49 [-0.64, -0.35] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 712 ≥ 26
docker_containers_memory memory_usage 10/10 272.79MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 486 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.78MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 490.56MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 206.65MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 363.41 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 408.04MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
docker_containers_cpu baseline 5 Crashed (exit code: 1) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@erikayasuda erikayasuda marked this pull request as ready for review April 8, 2026 15:45
@erikayasuda erikayasuda requested review from a team as code owners April 8, 2026 15:45
@erikayasuda erikayasuda requested a review from hush-hush April 8, 2026 15:45
@erikayasuda erikayasuda added the qa/done QA done before merge and regressions are covered by tests label Apr 8, 2026
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/container-platform The Container Platform Team team/injection-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants