Export DD_AGENT_HOST to library init containers for telemetry#48983
Export DD_AGENT_HOST to library init containers for telemetry#48983natitsechanski wants to merge 1 commit intomainfrom
Conversation
dd-octo-sts
bot
added
internal
Files inventory check summaryFile checks results against ancestor 19fea940: Results for datadog-agent_7.79.0~devel.git.490.ee0d311.pipeline.106707163-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates 30 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 19fea94 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -2.47 | [-5.43, +0.48] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.66 | [-0.02, +3.35] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.42 | [+0.26, +0.58] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.31 | [+0.25, +0.37] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.09 | [-0.14, +0.32] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.05 | [-0.39, +0.50] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.36, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.02 | [-0.04, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.01 | [-0.18, +0.20] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.10, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.55, +0.55] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.21, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.15, +0.14] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.03 | [-0.20, +0.13] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.06 | [-0.11, -0.01] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.12 | [-0.21, -0.03] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.23 | [-0.26, -0.20] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.26 | [-0.41, -0.12] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.27 | [-0.33, -0.21] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.37 | [-0.47, -0.27] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.38 | [-0.58, -0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.54 | [-0.76, -0.32] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -2.47 | [-5.43, +0.48] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 722 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.60MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 594 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.01MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 487.29MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 205.32MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 368.71 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 409.12MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
pawelchcki
left a comment
pawelchcki
left a comment
There was a problem hiding this comment.
On Data hoarding request, one praise and a nit or two.
LGTM
|
|
||
| patcher.AddEnvVarWithJoin("LD_PRELOAD", asAbsPath(injectorFilePath("launcher.preload.so")), ":") | ||
| patcher.AddEnvVar(corev1.EnvVar{Name: "DD_INJECT_SENDER_TYPE", Value: "k8s"}) | ||
| patcher.AddEnvVar(corev1.EnvVar{Name: "DD_INJECT_START_TIME", Value: strconv.FormatInt(time.Now().Unix(), 10)}) |
There was a problem hiding this comment.
i think we shoul keep this variable. and just measure both external and internal injection time.
DD_INJECT_START_TIME starts measuring at the moment the container is set to be scheduled (more/less), but also the time WILL include the time it takes to download, unpack and start the container. while in copy.sh we will only be able ot measure unpack time.
I'm a data hoarder, so I vote to keep it, but its a nonbinding vote :)
pkg/clusteragent/admission/mutate/autoinstrumentation/libraryinjection/init_container.go
Outdated
Show resolved
Hide resolved
| AutoDetected: autoDetected, | ||
| InjectionType: injectionType, | ||
| OnLibraryInjection: func(language string, status libraryinjection.MutationStatus) { | ||
| log.Infof("APM library injection: pod=%s/%s language=%s status=%s type=%s", |
There was a problem hiding this comment.
Opinion: I'm not sure if this is the best place to pu the this log, I would imagin it would be done around the code that execute the OnLibraryInjection, but I know little about the codebase
| OnLibraryInjection: func(language string, status libraryinjection.MutationStatus) { | ||
| log.Infof("APM library injection: pod=%s/%s language=%s status=%s type=%s", | ||
| pod.Namespace, pod.Name, language, status, injectionType) | ||
| }, |
There was a problem hiding this comment.
I don’t think we need a callback mechanism.
We could just log it directly in InjectAPMLibraries.
| Env: []corev1.EnvVar{ | ||
| { | ||
| Name: "DD_AGENT_HOST", | ||
| ValueFrom: &corev1.EnvVarSource{ | ||
| FieldRef: &corev1.ObjectFieldSelector{ | ||
| FieldPath: "status.hostIP", | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This only sets the host, not the port, and it does not respect the customer choice for how to connect to the Agent (hostname, IP, socket, CSI).
This logic already exists in the config mutator.
The issue seems to be that the config mutator runs before the library injection (ref).
I wonder if we could just swap the two 🤔
natitsechanski
force-pushed
the
natipirati/export-agent-host-to-init-containers
branch
2 times, most recently
from
618a340 to
ef58a34
Compare
…etry Swap mutator ordering so the APM mutator runs before the config webhook. This ensures library init containers already exist when the config webhook injects agent connection env vars (DD_AGENT_HOST, DD_TRACE_AGENT_URL, socket volumes). Removes the old timestamp file mechanism (c-init-time.*) and manual DD_AGENT_HOST injection in favor of the existing config mutator. Restores DD_INJECT_START_TIME. Replaces OnLibraryInjection callback with direct logging in InjectAPMLibraries.
natitsechanski
force-pushed
the
natipirati/export-agent-host-to-init-containers
branch
from
ef58a34 to
ee0d311
Compare
iamluc
left a comment
iamluc
left a comment
There was a problem hiding this comment.
LGTM! 👍
Nit: we could keep the c-init-time file for backward compatibility for a while.
|
DD_AGENT_HOST/DD_TRACE_AGENT_URL are already injected into init containers by the config webhook since 7.64.0 (#33907); the only change needed is in libdatadog-build (https://github.com/DataDog/libdatadog-build/pull/200) to consume them. |
3 participants
Summary
c-init-time.*) and manual DD_AGENT_HOST injection in favor of the existing config mutatorDD_INJECT_START_TIMEto measure end-to-end injection latency alongside init container copy durationOnLibraryInjectioncallback with direct logging inInjectAPMLibrariesRelated
copy-lib.shTest plan
go test ./pkg/clusteragent/admission/mutate/autoinstrumentation/...DD_INJECT_START_TIMEis set on app containers