Skip e2e tests on Windows to limit OOM failures#52027
Open
chouetz wants to merge 1 commit into
Open
Conversation
The test/e2e-framework module defaulted to should_test_condition: always, so its (platform-agnostic, cloud/pulumi-heavy) test suite was compiled and run on Windows. It is only consumed by test/new-e2e (already is_linux) and no agent/production code imports it, so it is unused on Windows. Gating it to is_linux removes one of the largest link steps from tests_windows-x64, reducing the memory pressure behind the recent VirtualAlloc errno=1455 OOM and 2h-timeout failures, with no loss of Windows coverage. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
I can only run on private repositories. |
Contributor
|
github-actions
Bot
added
the
short review
Contributor
Files inventory check summaryFile checks results against ancestor 2e9ccff8: Results for datadog-agent_7.81.0~devel.git.638.a9eafbe.pipeline.117819522-1_amd64.deb:No change detected |
chouetz
added
changelog/no-changelog
chouetz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a condition to skip e2e framework tests on Windows platforms to prevent out-of-memory allocation failures during test execution.
Motivation
The
tests_windows-x64job has been regularly failing with virtualalloc out-of-memory errors (errno 1455) since commit dc2eacd. Multiple allocation failures ranging from 8KB to 114KB have been reported, indicating memory pressure on the Windows test runner. By restricting the e2e framework tests to Linux, we can limit these OOM failures and allow the Windows test suite to complete successfully.Describe how you validated your changes
The change is a configuration update that conditionally excludes the e2e framework tests from running on Windows while maintaining normal execution on Linux platforms. This follows the existing pattern in modules.yml where platform-specific test conditions are already in use.
Additional Notes
This is a targeted fix to stabilize the Windows test pipeline. The e2e framework tests can continue to run on Linux where resource constraints are not an issue.
PR by Bits - View session in Datadog
Comment @DataDog to request changes