Remove the last BindEnv call

[hush-hush]

What does this PR do?

This adds a default to
"multi_region_failover.remote_configuration.refresh_interval" and "logs_config.api_key" and remove the linter exceptions for settings without types.

Motivation

Describe how you validated your changes

Additional Notes

[datadog-datadog-prod-us1]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/datadog-agent | oracle: [21.3.0-xe]     

Label analysis | release-note-check     

Label analysis | skip-qa-check     

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 28.74%
• Overall Coverage: 50.58% (-0.02%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e33e73c | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 54ed8217:

Results for datadog-agent_7.81.0~devel.git.619.e33e73c.pipeline.117813742-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 54ed821
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-24.0 KiB (0.00% reduction, +0.44% of buffer)	752.895 → 752.871 → 758.200
✅	agent_deb_amd64_fips	-8.0 KiB (0.00% reduction, +0.66% of buffer)	708.654 → 708.646 → 709.840
✅	agent_heroku_amd64	-8.0 KiB (0.00% reduction, +0.21% of buffer)	311.562 → 311.554 → 315.230
✅	agent_msi	-16.5 KiB (0.00% reduction, +0.12% of buffer)	617.083 → 617.067 → 630.600
✅	agent_rpm_amd64	-24.0 KiB (0.00% reduction, +0.44% of buffer)	752.879 → 752.855 → 758.170
✅	agent_rpm_amd64_fips	-8.0 KiB (0.00% reduction, +0.65% of buffer)	708.638 → 708.630 → 709.840
✅	agent_rpm_arm64	-16.0 KiB (0.00% reduction, +1.12% of buffer)	728.271 → 728.255 → 729.660
✅	agent_rpm_arm64_fips	-12.0 KiB (0.00% reduction, +1.09% of buffer)	687.789 → 687.778 → 688.860
✅	agent_suse_amd64	-24.0 KiB (0.00% reduction, +0.44% of buffer)	752.879 → 752.855 → 758.170
✅	agent_suse_amd64_fips	-8.0 KiB (0.00% reduction, +0.65% of buffer)	708.638 → 708.630 → 709.840
✅	agent_suse_arm64	-16.0 KiB (0.00% reduction, +1.12% of buffer)	728.271 → 728.255 → 729.660
✅	agent_suse_arm64_fips	-12.0 KiB (0.00% reduction, +1.09% of buffer)	687.789 → 687.778 → 688.860
✅	docker_agent_amd64	-19.99 KiB (0.00% reduction, +1.33% of buffer)	812.319 → 812.300 → 813.790
✅	docker_agent_arm64	-15.99 KiB (0.00% reduction, +0.68% of buffer)	812.744 → 812.728 → 815.030
✅	docker_agent_jmx_amd64	-20.01 KiB (0.00% reduction, +1.52% of buffer)	1003.260 → 1003.241 → 1004.550
✅	docker_agent_jmx_arm64	-16.0 KiB (0.00% reduction, +0.66% of buffer)	992.337 → 992.322 → 994.710
✅	docker_dogstatsd_amd64	-4.0 KiB (0.01% reduction, +5.68% of buffer)	39.841 → 39.837 → 39.910
✅	dogstatsd_deb_amd64	-8.0 KiB (0.03% reduction, +1.21% of buffer)	30.502 → 30.494 → 31.150
✅	dogstatsd_deb_arm64	-4.0 KiB (0.01% reduction, +0.38% of buffer)	28.499 → 28.495 → 29.530
✅	dogstatsd_rpm_amd64	-8.0 KiB (0.03% reduction, +1.21% of buffer)	30.502 → 30.494 → 31.150
✅	dogstatsd_suse_amd64	-8.0 KiB (0.03% reduction, +1.21% of buffer)	30.502 → 30.494 → 31.150

12 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	docker_cluster_agent_amd64	209.753 MiB
✅	docker_cluster_agent_arm64	222.847 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_arm64	37.946 MiB
✅	docker_host_profiler_amd64	304.525 MiB
✅	docker_host_profiler_arm64	315.638 MiB
✅	iot_agent_deb_amd64	45.671 MiB
✅	iot_agent_deb_arm64	42.389 MiB
✅	iot_agent_deb_armhf	43.184 MiB
✅	iot_agent_rpm_amd64	45.671 MiB
✅	iot_agent_suse_amd64	45.670 MiB

[jszwedko]

I see this matches the default for the top-level remote_configuration.refresh_interval that was introduced in #51433 but it strikes me a bit odd as a default since it is lower than the minimum assigned at:

https://github.com/DataDog/datadog-agent/blob/main/pkg/config/remote/service/service.go#L448

Maybe the default should be the minumum?

Also, will the switch to IsConfigured effectively disable refresh by default? Is that the correct behavior?

[aya-shimizu24]

From looking at the comments of IsSet vs IsConfigured, I think you're right, it will go from “use the default refresh interval if present” to “only refresh when the user explicitly configured the interval.”
I'm assuming that's what you're intending based on this change, are you planning on having a refresh interval var somewhere? If you weren't & were planning on just using the default, I would recommend having a real min instead of 0 so you don't get a bunch of warning logs

[aya-shimizu24]

Also in re to the question about default vs min refresh interval, that's on purpose! The 5s minimalRefreshInterval is the absolute lowest duration poll interval the agent is willing to go but the 1min defaultRefreshInterval is the normal poll loop interval that is used at agent startup, so that is our default.
Where defaultRefreshInterval can be overridden statically via configs, or at runtime via backend recommendation

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3549b49a-04c5-4f44-b7b6-6ff4c2f13f13

Baseline: 54ed821
Comparison: e33e73c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+0.61	[+0.55, +0.66]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.61	[-0.66, -0.57]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-1.16	[-1.41, -0.91]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-2.16	[-3.20, -1.12]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	145.54MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	726.03KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	476.71MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	179.09MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.37MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	344.66 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	396.82MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.