[AGENT-16334] Disable workloadmeta process collector on IoT Agent#52048
[AGENT-16334] Disable workloadmeta process collector on IoT Agent#52048ian28223 wants to merge 1 commit into
Conversation
dd-octo-sts
Bot
added
internal
github-actions
Bot
added
the
short review
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ian28223
force-pushed
the
ian.bucad/agent-16334-iot-process-collector-disabled
branch
from
e5a8865 to
5ca092f
Compare
github-actions
Bot
added
medium review
ian28223
force-pushed
the
ian.bucad/agent-16334-iot-process-collector-disabled
branch
from
5ca092f to
b76d5e4
Compare
ian28223
added
the
qa/done
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b76d5e48fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Files inventory check summaryFile checks results against ancestor 2b4556d2: Results for datadog-agent_7.81.0~devel.git.646.d986b3d.pipeline.117886072-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
27 successful checks with minimal change (< 2 KiB)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 2b4556d Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle_all_features | memory utilization | -2.17 | [-2.21, -2.13] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -3.27 | [-3.32, -3.22] | 1 | Logs bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory utilization | -6.23 | [-6.46, -5.99] | 1 | Logs bounds checks dashboard |
| ✅ | quality_gate_logs | % cpu utilization | -44.14 | [-44.94, -43.33] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 146.73MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 734.78KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 480.22MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.13MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 182.73MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.03MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 343.36 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 398.72MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (ddprof)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle_all_features | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | comparison | 10 | Oom killed | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
The process collector unconditionally attempts to connect to the system-probe socket for service discovery. On the IoT Agent, system-probe is never present, so after the 5-minute startup grace period the socket connection error is logged as ERROR on every collection tick with no user-facing config to suppress it. Guard Start() with a flavor check so the collector is disabled early on IotAgent, mirroring the existing pattern in the remote process collector. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ian28223
force-pushed
the
ian.bucad/agent-16334-iot-process-collector-disabled
branch
from
b76d5e4 to
d986b3d
Compare
| // GetBinaryFlavor returns the flavor set at binary startup, ignoring the iot_host config key. | ||
| func GetBinaryFlavor() string { | ||
| return agentFlavor | ||
| } |
There was a problem hiding this comment.
Why is this needed ? Do we allow users which set iot_host to use workloadmeta / process collection ?
2 participants
What does this PR do?
Adds a guard to the workloadmeta process collector's
Start()method that returnserrors.NewDisabledwhen running as the IoT Agent binary. This prevents the collector from starting service discovery goroutines that unconditionally attempt to connect to the system-probe socket — a socket that is never created on the IoT Agent.Also adds
GetBinaryFlavor()topkg/util/flavorto distinguish the actual binary flavor from the config-promoted flavor (iot_host: true). The guard usesGetBinaryFlavor()so it only fires for the IoT Agent binary, not a full agent withiot_host: truethat may still be running system-probe.Motivation
Fixes AGENT-16334. Customers running the IoT Agent on Linux see repeated ERROR-level log spam:
Root cause:
discovery.enableddefaults totrueon Linux in the system probe config. The collector's startup grace period (check_system_probe_startup_time, default 5 minutes) suppresses the error initially, then logs it as ERROR on every collection tick. There is no user-facing config indatadog.yamlto stop it — the only workaround requires creating/etc/datadog-agent/system-probe.yaml, a file the IoT Agent doesn't ship with.The fix mirrors the existing pattern in
comp/core/workloadmeta/collectors/internal/remote/processcollector/process_collector.go.Describe how you validated your changes
TestStartConfigurationIoTAgenttoprocess_collector_test.go: sets the IoT binary flavor, enables all four feature flags (process collection, service discovery, language detection, GPU monitoring), and assertsStart()returnserrors.NewDisabled. Confirms the guard fires before any individual config check.dda inv agent.build.gofmtclean.//go:build linux && testand cannot run on macOS — Linux CI will be the confirmation.Additional Notes
No behavior change for any non-IoT flavor. The existing
TestStartConfigurationtest suite covers the non-IoT disabled/enabled cases and is unmodified.