[NETPATH-666] Create Source Public IP Config

[AyyLam]

What does this PR do?

This PR adds an option for users to disable collecting the source public IP through these sources:

"https://icanhazip.com/",         // owned by cloudflare
"https://ipinfo.io/ip",           // same as our GeoIP info provider
"https://checkip.amazonaws.com/", // Amazon
"https://api.ipify.org/",         // Dedicated Public IP info and GeoIP info provider
"https://whatismyip.akamai.com/", // Akamai is a CDN Provider

This is mainly relevant in cases where users want to block internet access so public ip resolution always fails.

Configuration is done either in the datadog.yaml level, on a per instance level, or disable on the init_config level:

network_path:
  connections_monitoring:
    enabled: true
  collector:
    disable_source_public_ip_collection: true

instances:
  - hostname: spotify.com
    protocol: TCP
    port: 443
    disable_source_public_ip_collection: true

init_config:
    disable_source_public_ip_collection: true

Motivation

https://datadoghq.atlassian.net/browse/NETPATH-666

Describe how you validated your changes

Testing was done locally in the linux dev box for both dynamic paths and static paths

Additional Notes

[AyyLam]

This is the main change that causes the runner to use the config instead of enabling it by default.

this boolean is checked here in the datadog-traceroute repo
https://github.com/DataDog/datadog-traceroute/blob/main/traceroute/traceroute.go#L109-L124

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 94a9ac04:

Results for datadog-agent_7.82.0~devel.git.30.872afe1.pipeline.118939253-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e0ee531e-896e-490d-ad84-bac34db295b5

Baseline: 94a9ac0
Comparison: 872afe1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.12	[+0.07, +2.17]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.03	[-0.02, +0.08]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.11	[-0.15, -0.07]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.78	[-1.02, -0.53]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	144.05MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	579.55KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	479.33MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	0.89MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	179.60MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.29MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	355.64 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	385.44MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.86GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 94a9ac0
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_msi	+2.5 KiB (0.00% increase, -0.02% of buffer)	618.080 → 618.082 → 630.600
✅	agent_rpm_arm64	+4.6 KiB (0.00% increase, -0.27% of buffer)	728.021 → 728.025 → 729.660
✅	agent_suse_arm64	+4.6 KiB (0.00% increase, -0.27% of buffer)	728.021 → 728.025 → 729.660
✅	docker_agent_arm64	+4.59 KiB (0.00% increase, -0.17% of buffer)	812.383 → 812.388 → 815.030
✅	docker_agent_jmx_arm64	+4.59 KiB (0.00% increase, -0.16% of buffer)	991.977 → 991.981 → 994.710

28 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.637 MiB
✅	agent_deb_amd64_fips	708.359 MiB
✅	agent_heroku_amd64	310.993 MiB
✅	agent_rpm_amd64	752.621 MiB
✅	agent_rpm_amd64_fips	708.343 MiB
✅	agent_rpm_arm64_fips	687.322 MiB
✅	agent_suse_amd64	752.621 MiB
✅	agent_suse_amd64_fips	708.343 MiB
✅	agent_suse_arm64_fips	687.322 MiB
✅	docker_agent_amd64	812.061 MiB
✅	docker_agent_jmx_amd64	1003.002 MiB
✅	docker_cluster_agent_amd64	209.858 MiB
✅	docker_cluster_agent_arm64	222.960 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.877 MiB
✅	docker_dogstatsd_arm64	37.946 MiB
✅	docker_host_profiler_amd64	305.345 MiB
✅	docker_host_profiler_arm64	316.462 MiB
✅	dogstatsd_deb_amd64	30.534 MiB
✅	dogstatsd_deb_arm64	28.531 MiB
✅	dogstatsd_rpm_amd64	30.534 MiB
✅	dogstatsd_suse_amd64	30.534 MiB
✅	iot_agent_deb_amd64	45.945 MiB
✅	iot_agent_deb_arm64	42.648 MiB
✅	iot_agent_deb_armhf	43.444 MiB
✅	iot_agent_rpm_amd64	45.945 MiB
✅	iot_agent_suse_amd64	45.944 MiB

[AlexandreYang]

@codex review

[AlexandreYang]

@DataDog review

[datadog-datadog-prod-us1]

I can only run on private repositories.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6cc432c10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ken-schneider]

Other than adding the init_config option, this looks good

[merchristK]

lgtm for action-platform

[Fabrice-Matrat]

LGTM