[autoscaling] Re-sync local DPA on ad.datadoghq.com/tags change

[clamoriniere]

What does this PR do?

Tags set via the ad.datadoghq.com/tags annotation on a local-owner DatadogPodAutoscaler now reach the datadog.cluster-agent.autoscaling.workload.* metrics on the next reconcile, instead of only after a Cluster Agent restart or spec edit.

Motivation

For local-owner DPAs, UpdateFromPodAutoscaler short-circuits when the metadata fingerprint is unchanged. The fingerprint didn't include ad.datadoghq.com/tags, and annotation edits don't bump .metadata.generation, so the cached upstream CR (read at metric-generation time) stayed stale. The annotation is now part of the watched key list.

Describe how you validated your changes

Extended TestUpdateFromPodAutoscalerResyncsOnWatchedMetadata to assert a tags-annotation-only edit refreshes the cached CR. dda inv test + dda inv linter.go pass on the package.

🤖 Assisted by Claude:claude-opus-4-8

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61560f506e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Add the Bazel dep for the new Kubernetes import

This new direct import is not mirrored in pkg/clusteragent/autoscaling/workload/model/BUILD.bazel: the model target's deps still include //pkg/clusteragent/autoscaling and //pkg/util/pointer, but not //pkg/util/kubernetes. In Bazel/strict-deps builds of //pkg/clusteragent/autoscaling/workload/model with the kubeapiserver sources enabled, this import is unresolved as a declared dependency, so the Bazel path will fail even though the dda inv test path may pass.

Useful? React with 👍 / 👎.

[datadog-prod-us1-5]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-agent | oracle: [21.3.0-xe]     

DataDog/datadog-agent | tests_linux-x64-py3_hybrid     

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.85% (-0.05%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ae29c10 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 8d78fe58:

Results for datadog-agent_7.82.0~devel.git.128.ae29c10.pipeline.119757834-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8d78fe5
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.842 MiB
✅	agent_deb_amd64_fips	708.514 MiB
✅	agent_heroku_amd64	310.756 MiB
✅	agent_rpm_amd64	752.826 MiB
✅	agent_rpm_amd64_fips	708.497 MiB
✅	agent_rpm_arm64	728.153 MiB
✅	agent_rpm_arm64_fips	687.455 MiB
✅	agent_suse_amd64	752.826 MiB
✅	agent_suse_amd64_fips	708.497 MiB
✅	agent_suse_arm64	728.153 MiB
✅	agent_suse_arm64_fips	687.455 MiB
✅	docker_agent_amd64	812.212 MiB
✅	docker_agent_arm64	812.512 MiB
✅	docker_agent_jmx_amd64	1003.109 MiB
✅	docker_agent_jmx_arm64	992.062 MiB
✅	docker_cluster_agent_amd64	208.605 MiB
✅	docker_cluster_agent_arm64	221.754 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.433 MiB
✅	docker_dogstatsd_arm64	37.569 MiB
✅	docker_host_profiler_amd64	305.369 MiB
✅	docker_host_profiler_arm64	316.481 MiB
✅	dogstatsd_deb_amd64	30.096 MiB
✅	dogstatsd_deb_arm64	28.120 MiB
✅	dogstatsd_rpm_amd64	30.096 MiB
✅	dogstatsd_suse_amd64	30.096 MiB
✅	iot_agent_deb_amd64	45.946 MiB
✅	iot_agent_deb_arm64	42.645 MiB
✅	iot_agent_deb_armhf	43.446 MiB
✅	iot_agent_rpm_amd64	45.947 MiB
✅	iot_agent_suse_amd64	45.945 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8fad0fd7-6823-42a1-acf0-ecd9b81dd561

Baseline: 8d78fe5
Comparison: ae29c10
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+0.05	[+0.01, +0.09]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.01	[-0.04, +0.05]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-1.15	[-1.40, -0.91]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-1.30	[-2.36, -0.23]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	146.55MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	578.53KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	490.10MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	0.89MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	182.84MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.18MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	350.32 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	392.76MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.86GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[clamoriniere]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-06-18 08:24:37 UTC ℹ️ Start processing command /merge

---

2026-06-18 08:24:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2026-06-18 12:28:03 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time