[RUM-11993] Add trace context and GraphQL fields to sendErrorEvent#2798
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intodevelopfrom Apr 8, 2026
Conversation
saraSr5
force-pushed
the
sara.susano/RUM-11993-error-event-trace-graphql-fields
branch
from
3641cae to
256edf5
Compare
maxep
requested changes
Mar 31, 2026
Member
maxep
left a comment
maxep
left a comment
There was a problem hiding this comment.
Great work! Looks very good and very well covered in tests 🥇
I think we can improve the RUMResourceScope implementation by using a shared type for Graphql data, see my comment.
maxep
previously approved these changes
Apr 1, 2026
Member
maxep
left a comment
maxep
left a comment
There was a problem hiding this comment.
Looks great! Just a minor suggestion
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
sara.susano/RUM-11993-error-event-trace-graphql-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds trace context (
traceId,spanId,parentSpanId,rulePsr) and GraphQL fields tosendErrorEventinRUMResourceScope, bringing it to parity withsendResourceEvent.Why
These fields were missing from the error event path, causing trace correlation and GraphQL error data to be lost when a resource load fails.
Changes
RUMDataModelsand Obj-C bridge to add the new fields toRUMErrorEventsendErrorEventextractTraceAttributes()andextractGraphQLAttributes()to eliminate duplication between the two send pathsdecodeGraphQLResponseErrorsbase with two typed wrappers